[oe] [meta-networking][PATCH 2/8] freeradius: add new recipe

[Huang, Jie (Jackie)]

> -----Original Message-----
> From: Joe MacDonald [mailto:Joe_MacDonald at mentor.com]
> Sent: Wednesday, May 10, 2017 00:37
> To: Huang, Jie (Jackie)
> Cc: openembedded-devel at lists.openembedded.org
> Subject: Re: [oe] [meta-networking][PATCH 2/8] freeradius: add new recipe
> 
> Sorry to resurrect a v1 patch but I've lost the v2 and the list seems
> to have eaten my original reply to that one.  Here's my comments from it
> (and the reason why the current patch has been marked rejected in
> patchwork: https://patchwork.openembedded.org/patch/139452/)
> 
> [[oe] [meta-networking][PATCH 2/8 v2] freeradius: add new recipe] On 17.04.26
> (Wed 16:22) jackie.huang at windriver.com wrote:
> 
> > From: Jackie Huang <jackie.huang at windriver.com>
> >
> > FreeRADIUS is an Internet authentication daemon,
> > which implements the RADIUS protocol, as defined
> > in RFC 2865 (and others).
> >
> > Signed-off-by: Jackie Huang <jackie.huang at windriver.com>
> > ---
> >  .../freeradius/files/freeradius                    | 110 ++++++++++
> >  .../freeradius-avoid-searching-host-dirs.patch     | 194 +++++++++++++++++
> >  ...radius-configure.ac-add-option-for-libcap.patch |  70 ++++++
> >  ...dius-configure.ac-allow-cross-compilation.patch |  31 +++
> >  .../files/freeradius-enble-user-in-conf.patch      |  28 +++
> >  ...eeradius-fix-error-for-expansion-of-macro.patch |  61 ++++++
> >  ...ius-fix-issues-related-to-m4-include-path.patch | 236
> +++++++++++++++++++++
> >  .../freeradius-fix-quoting-for-BUILT_WITH.patch    |  55 +++++
> >  .../files/freeradius-libtool-detection.patch       |  89 ++++++++
> >  .../freeradius-libtool-do-not-use-jlibtool.patch   | 160 ++++++++++++++
> >  .../freeradius-rlm_python-add-PY_INC_DIR.patch     |  33 +++
> >  .../freeradius/files/radiusd-volatiles.conf        |   2 +
> >  .../freeradius/files/radiusd.service               |  16 ++
> >  .../freeradius/files/volatiles.58_radiusd          |   3 +
> >  .../freeradius/freeradius_3.0.12.bb                | 223 +++++++++++++++++++
> 
> This is an old version of freeradius, as evinced by your SRC_URI:
> 
> > +SRC_URI = "ftp://ftp.freeradius.org/pub/freeradius/old/freeradius-server-
> ${PV}.tar.bz2 \
> 
> Why not bring the current version (3.0.13) in since it's a new recipe
> and save a later update?

Sorry I missed checking this one, I will update it to 3.0.13 and re-send.

> 
> > diff --git a/meta-networking/recipes-connectivity/freeradius/files/freeradius-
> avoid-searching-host-dirs.patch b/meta-networking/recipes-
> connectivity/freeradius/files/freeradius-avoid-searching-host-dirs.patch
> > new file mode 100644
> > index 000000000..8ab23d3ef
> > --- /dev/null
> > +++ b/meta-networking/recipes-connectivity/freeradius/files/freeradius-
> avoid-searching-host-dirs.patch
> > @@ -0,0 +1,194 @@
> > +From dc41591d5ceb18900ec85894f8f7b7bb44bb3bd9 Mon Sep 17 00:00:00
> 2001
> > +From: Jackie Huang <jackie.huang at windriver.com>
> > +Date: Mon, 4 Jan 2016 01:44:04 -0500
> > +Subject: [PATCH] avoid searching host dirs
> > +
> > +Upstream-Status: Inappropriate [cross-compile specific]
> 
> I don't know if that's specifically a reason to be inappropriate for
> upstream.  :-)
> 
> Anyway, given that some of the patches were submitted upstream, as you
> noted elsewhere, it may be that the current version won't need them at
> all.

I will check with the current version.

Thanks,
Jackie

> 
> --
> -Joe MacDonald.
> :wq