[oe] [meta-oe] [PATCH] xerces-c: fix a wrong PACKAGECONFIG option

[Ming Liu]

Hi, Martin:

Arha, thanks for the review, will send a V2.

//Ming Liu

2017-05-16 13:12 GMT+02:00 Martin Jansa <martin.jansa at gmail.com>:

> You should use ${prefix} if there isn't better variable instead of
> hardcoding /usr
>
> On Tue, May 16, 2017 at 12:49 PM, <liu.ming50 at gmail.com> wrote:
>
>> From: Ming Liu <peter.x.liu at external.atlascopco.com>
>>
>> In xerces-c's configure, these options is being referred as follows:
>> ......
>>     curl_flags="-I$with_curl/include"
>>     curl_libs="-L$with_curl/lib -lcurl"
>>
>>     icu_flags="-I$with_icu/include"
>>     icu_libs="-L$with_icu/lib -licuuc -licudata"
>> ......
>>
>> so they shouldn't be set to ${STAGING_DIR}, use
>> ${STAGING_DIR_TARGET}/usr instead.
>>
>> Signed-off-by: Ming Liu <peter.x.liu at external.atlascopco.com>
>> ---
>>  meta-oe/recipes-devtools/xerces-c/xerces-c_3.1.4.bb | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta-oe/recipes-devtools/xerces-c/xerces-c_3.1.4.bb
>> b/meta-oe/recipes-devtools/xerces-c/xerces-c_3.1.4.bb
>> index b848b06..3bcedd7 100644
>> --- a/meta-oe/recipes-devtools/xerces-c/xerces-c_3.1.4.bb
>> +++ b/meta-oe/recipes-devtools/xerces-c/xerces-c_3.1.4.bb
>> @@ -16,8 +16,8 @@ SRC_URI[sha256sum] = "9408f12c1628ecf80730bedbe8b2c
>> aad810edd01bb4c66f77b60c873e8
>>  inherit autotools
>>
>>  PACKAGECONFIG ??= "curl icu"
>> -PACKAGECONFIG[curl] = "--with-curl=${STAGING_DIR},--with-curl=no,curl"
>> -PACKAGECONFIG[icu] = "--with-icu=${STAGING_DIR},--with-icu=no,icu"
>> +PACKAGECONFIG[curl] = "--with-curl=${STAGING_DIR_TAR
>> GET}/usr,--with-curl=no,curl"
>> +PACKAGECONFIG[icu] = "--with-icu=${STAGING_DIR_TARG
>> ET}/usr,--with-icu=no,icu"
>>
>>  do_install_prepend () {
>>      sed -i -e 's:-L${STAGING_DIR}/lib:-L\$\{libdir\}:g' ${B}/xerces-c.pc
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
>
>