[oe] [PATCH 1/2] libndp: switch to github uri. libndp.org is unstable

Anders Darander anders at chargestorm.se
Wed May 17 06:35:23 UTC 2017


Hi,

* Gianfranco Costamagna <costamagna.gianfranco at gmail.com> [170516 13:15]:

First, the subject should have included [PATCH v2 1/2] instead of just
[PATCH 1/2], as this really is the 2nd version. (This applies to the
whole series).

> From: Gianfranco Costamagna <gianfranco.costamagna at abinsula.com>

> Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna at abinsula.com>
> ---

Down here, a changelog for the changes between v1 and v2. (At least if
they'r not covered by a cover letter).

>  meta-oe/recipes-connectivity/libndp/libndp_1.6.bb | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

> -SRC_URI = "http://libndp.org/files/${BPN}-${PV}.tar.gz \
> +SRC_URI = "git://github.com/jpirko/libndp;branch=master;tag=v${PV} \

Pleasen, remove tag=v${PV} from the SRC_URI. Instead, add a SRVREV= the
SHA1. If you use a tag, bitbake will reach out the git server upon each
build to verify the SHA1 of the tag. That'll break off-line builds etc.

Cheers,
Anders

>             file://0001-include-sys-select.h-for-fd_-definitions.patch \
>             "
> -SRC_URI[md5sum] = "1e54d26bcb4a4110bc3f90c5dd04f1a7"
> -SRC_URI[sha256sum] = "0c7dfa84e013bd5e569ef2c6292a6f72cfaf14f4ff77a77425e52edc33ffac0e"
> +
> +S = "${WORKDIR}/git"
> +

>  inherit autotools
-- 
Anders Darander, Senior System Architect
ChargeStorm AB / eStorm AB



More information about the Openembedded-devel mailing list