[oe] [meta-oe][PATCH] rrdtool: add gettext-native dependency

[Randy MacLeod]

On 2017-05-17 03:45 PM, Khem Raj wrote:
> On Wed, May 17, 2017 at 11:15 AM, Randy MacLeod
> <Randy.MacLeod at windriver.com> wrote:
>> Add gettext-native dependency to use autopoint.
>>
>> When building rrdtool for a 'tiny' distro, ie one that does
>> not have internationalization support in glibc, configure
>> fails with the error:
>>    autoreconf: failed to run autopoint: No such file or directory
>> autopoint is part of gettext so add that native dependency.
>> This must happen transitively for builds using a regular configuration
>> of glibc.
>>
>> Signed-off-by: Randy MacLeod <Randy.MacLeod at windriver.com>
>> ---
>>  meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb b/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb
>> index db2df28a0..160dea58d 100644
>> --- a/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb
>> +++ b/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb
>> @@ -4,7 +4,7 @@ HOMEPAGE = "http://oss.oetiker.ch/rrdtool/"
>>  LICENSE = "GPLv2"
>>  LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=3349111ed0533471494beec99715bc9d"
>>
>> -DEPENDS = "libpng zlib cairo pango glib-2.0 libxml2 groff-native"
>> +DEPENDS = "libpng zlib cairo pango glib-2.0 libxml2 groff-native gettext-native"
>
> perhaps inherit gettext is more appropriate ?

That's already there:

$ grep gettext `find * -name "rrdtoo*bb"`
inherit cpan autotools-brokensep gettext pythonnative python-dir systemd

and in meta/classes/gettext.bbclass:

def gettext_dependencies(d):
     if d.getVar('INHIBIT_DEFAULT_DEPS') and not oe.utils.inherits(d, 
'cross-canadian'):
         return ""
     if d.getVar('USE_NLS') == 'no':
         return "gettext-minimal-native"
     return d.getVar('DEPENDS_GETTEXT', False)

I could install autopoint as part of gettext-minimal-native
but I need to dig a bit more and learn what the heck autopoint
is being used for... maybe I need to fix rrdtool's configure
script and/or see if that's done already in the newer version.

../Randy


>
>
>>
>>  SRCREV = "61f116744262c4c18922dcf806e496715f199669"
>>  PV = "1.6.0"
>> --
>> 2.11.0
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


-- 
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, 
Canada, K2K 2W5