[oe] [PATCH][v2 10/13] tumbler: ensure thumbnails work properly

[Andreas Müller]

On Sat, Nov 11, 2017 at 2:29 PM, Andreas Müller <schnitzeltony at gmail.com>
wrote:

> From: Andreas Müller <schnitzeltony at googlemail.com>
>
> After some builds link tumbler-cache-plugin.so is not prperly created
> causing:
> | Failed to load the cache plugin "tumbler-cache-plugin.so":
> /usr/lib/tumbler-1/plugins/cache/tumbler-cache-plugin.so: cannot open
> shared object file: No such file or directory
>
> Signed-off-by: Andreas Müller <schnitzeltony at googlemail.com>
> ---
>  meta-xfce/recipes-xfce/tumbler/tumbler_0.1.31.bb | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/meta-xfce/recipes-xfce/tumbler/tumbler_0.1.31.bb
> b/meta-xfce/recipes-xfce/tumbler/tumbler_0.1.31.bb
> index 1f5419a..1786eff 100644
> --- a/meta-xfce/recipes-xfce/tumbler/tumbler_0.1.31.bb
> +++ b/meta-xfce/recipes-xfce/tumbler/tumbler_0.1.31.bb
> @@ -15,6 +15,12 @@ INSANE_SKIP_${PN} = "dev-so"
>  PACKAGECONFIG ??= ""
>  PACKAGECONFIG[gstreamer-thumbnailer] = "--enable-gstreamer-
> thumbnailer,--disable-gstreamer-thumbnailer,gstreamer1.0
> gstreamer1.0-plugins-base"
>
> +do_install_append() {
> +    # Makefile seems to race on creation of symlink. So ensure creation
> here
> +    # until fixed properly
> +    ln -sf tumbler-xdg-cache.so ${D}${libdir}/tumbler-1/
> plugins/cache/tumbler-cache-plugin.so
> +}
> +
>  FILES_${PN} += "${datadir}/dbus-1/services \
>                  ${libdir}/tumbler-1/tumblerd \
>                  ${libdir}/tumbler-1/plugins/*.so \
> --
> 2.9.5
>
> Just saw that this was not applied. For clarification: The first version
of this patch was buggy and Khem pointed that out. Later I checked further:
The problem persists and is sporadic (some race in Makefile?). So at the
time I created the patch I thought it fixed the problem but fix was random
only. Then I fixed the patch and sent it in V2.

My suggestion:
* I will rebase this patch (tumbler was updated) and resend again for
master.
* Later when rebased version is in master I will send this to apply for
rocko.

Is that OK or is there anything else wrong with this patch?

Regards

Andreas