[oe] [meta-oe][PATCH] Fix PACKAGES assignment for fftw

Andreas Müller schnitzeltony at gmail.com
Thu Nov 23 15:19:51 UTC 2017


On Thu, Nov 23, 2017 at 3:40 PM, Koen Kooi <koen at dominion.thruhere.net>
wrote:

> Op 23-11-17 om 14:25 schreef Vladan Jovanovic:
> > fftw recipe using wrong operator for modifying PACKAGES variable.
>
> Please explain what's wrong with it and show a buildhistory-diff between
> the 2 builds.
>
>
> > ---
> >  meta-oe/recipes-support/fftw/fftw_3.3.6.bb | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
> b/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
> > index ed14e16..e13684c 100644
> > --- a/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
> > +++ b/meta-oe/recipes-support/fftw/fftw_3.3.6.bb
> > @@ -65,12 +65,12 @@ do_install() {
> >  }
> >
> >
> > -PACKAGES =+ "libfftw libfftwl libfftwf"
> > +PACKAGES += "libfftw libfftwl libfftwf"
> >  FILES_libfftw = "${libdir}/libfftw3.so.* ${libdir}/libfftw3_*.so.*"
> >  FILES_libfftwl = "${libdir}/libfftw3l.so.* ${libdir}/libfftw3l_*.so.*"
> >  FILES_libfftwf = "${libdir}/libfftw3f.so.* ${libdir}/libfftw3f_*.so.*"
> >
> > -PACKAGES =+ "fftw-wisdom fftwl-wisdom fftwf-wisdom fftw-wisdom-to-conf"
> > +PACKAGES += "fftw-wisdom fftwl-wisdom fftwf-wisdom fftw-wisdom-to-conf"
> >  FILES_fftw-wisdom = "${bindir}/fftw-wisdom"
> >  FILES_fftwl-wisdom = "${bindir}/fftwl-wisdom"
> >  FILES_fftwf-wisdom = "${bindir}/fftwf-wisdom"
> >
>
>
> NAK: This breaks packaging: All libdir binaries go to fftw package. Split
was intended.

Andreas



More information about the Openembedded-devel mailing list