[oe] [meta-python][PATCH] python-grpcio: only modify the compiler arguments on the target build

[Khem Raj]

On Mon, Nov 27, 2017 at 11:36 AM, Derek Straka <derek at asterius.io> wrote:
> Sure.  The change you had originally made removed the -std=c++11
> (https://patchwork.openembedded.org/patch/142706/ -
> 2d07918e9cc6e03f8f864605c84290b66b81e998). The -std=c++11 is required to
> build native on Ubuntu 16.04 with gcc 5.4.0 since the default mode was
> -std=gnu++98 for gcc before 6.0.  Is there a standard way to query the build
> host compiler version and add the -std=c++11?  I can also just drop the
> -std=gnu99 portion, but I assume you wanted them both removed?
>

I think its ok to not apply this patch for native builds.

> On another note, any idea if recipes created with BBCLASSEXTEND = "native"
> are included in the world build?  I'd expect to see a failure here because I
> believe Martin was using 16.04.
>

If its not in the depchain for target packages its wont be built.

> On Mon, Nov 27, 2017 at 1:14 PM, Khem Raj <raj.khem at gmail.com> wrote:
>>
>>
>>
>> On 11/27/17 7:55 AM, Derek Straka wrote:
>>>
>>> The modification causes issues with the native builds of the package:
>>>
>>> src/core/lib/surface/lame_client.cc: In function ‘grpc_channel*
>>> grpc_lame_client_channel_create(const char*, grpc_status_code, const
>>> char*)’:
>>> src/core/lib/surface/lame_client.cc:178:3: warning: ‘auto’ changes
>>> meaning in C++11; please remove it [-Wc++0x-compat]
>>>      auto chand = reinterpret_cast<grpc_core::ChannelData
>>> *>(elem->channel_data);
>>>      ^
>>> src/core/lib/surface/lame_client.cc:178:8: error: ‘chand’ does not name a
>>> type
>>>      auto chand = reinterpret_cast<grpc_core::ChannelData
>>> *>(elem->channel_data);
>>>
>>
>> This looks like an option issue for different compiler version on your
>> build host. The patch is trying to paper over it. I think it will be better
>> if we could fix the code to be using right options across different compiler
>> versions.
>>
>>
>>> Signed-off-by: Derek Straka <derek at asterius.io>
>>> ---
>>>   meta-python/recipes-devtools/python/python-grpcio_1.7.0.bb
>>> | 2 +-
>>>   meta-python/recipes-extended/python-pyparted/python-pyparted_3.10.7.bb
>>> | 2 --
>>>   meta-python/recipes-extended/python-pyparted/python3-pyparted_3.10.7.bb
>>> | 2 --
>>>   3 files changed, 1 insertion(+), 5 deletions(-)
>>>
>>> diff --git a/meta-python/recipes-devtools/python/python-grpcio_1.7.0.bb
>>> b/meta-python/recipes-devtools/python/python-grpcio_1.7.0.bb
>>> index 3ca7d53..d4d869d 100644
>>> --- a/meta-python/recipes-devtools/python/python-grpcio_1.7.0.bb
>>> +++ b/meta-python/recipes-devtools/python/python-grpcio_1.7.0.bb
>>> @@ -4,7 +4,7 @@ SECTION = "devel/python"
>>>     DEPENDS = "python-protobuf"
>>>   -SRC_URI +=
>>> "file://0001-setup.py-Do-not-mix-C-and-C-compiler-options.patch \
>>> +SRC_URI_append_class-target =
>>> "file://0001-setup.py-Do-not-mix-C-and-C-compiler-options.patch \
>>>              "
>>>   RDEPENDS_${PN} = "python-enum34 \
>>>                     python-futures \
>>> diff --git
>>> a/meta-python/recipes-extended/python-pyparted/python-pyparted_3.10.7.bb
>>> b/meta-python/recipes-extended/python-pyparted/python-pyparted_3.10.7.bb
>>> index 8a15a89..81d61c6 100644
>>> ---
>>> a/meta-python/recipes-extended/python-pyparted/python-pyparted_3.10.7.bb
>>> +++
>>> b/meta-python/recipes-extended/python-pyparted/python-pyparted_3.10.7.bb
>>> @@ -1,7 +1,5 @@
>>>   require python-pyparted.inc
>>>   -DEPENDS += "python-re"
>>> -
>>>   PV = "3.10.7+git${SRCPV}"
>>>     inherit distutils
>>> diff --git
>>> a/meta-python/recipes-extended/python-pyparted/python3-pyparted_3.10.7.bb
>>> b/meta-python/recipes-extended/python-pyparted/python3-pyparted_3.10.7.bb
>>> index ff72c2a..4d6f97b 100644
>>> ---
>>> a/meta-python/recipes-extended/python-pyparted/python3-pyparted_3.10.7.bb
>>> +++
>>> b/meta-python/recipes-extended/python-pyparted/python3-pyparted_3.10.7.bb
>>> @@ -1,7 +1,5 @@
>>>   require python-pyparted.inc
>>>   -DEPENDS += "python3-re"
>>> -
>>>   PV = "3.10.7+git${SRCPV}"
>>>     inherit distutils3
>>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>