[oe] [meta-python][PATCH] Add python pandas recipes
Guy Morand
guy at guy-morand.ch
Tue Oct 3 08:31:55 UTC 2017
Hi,
Thanks for reviwing my patch, almost there! still learning community
conventions :p!
My arguments for md5sums was if the PV changes, I guess both recipes
will have to be updated. Since it's DRYer and other recipes are made
this way, I will fix it!
"-s" never hurts!
I hope the third attempt will be the good one!
Regards,
Guy
On 10/01/2017 08:41 PM, Martin Jansa wrote:
> Also missing Signed-off-by line.
>
> On Fri, Sep 29, 2017 at 7:37 PM, Tim Orling
> <timothy.t.orling at linux.intel.com
> <mailto:timothy.t.orling at linux.intel.com>> wrote:
>
>
> > On Sep 29, 2017, at 1:26 AM, Guy Morand <guy at guy-morand.ch
> <mailto:guy at guy-morand.ch>> wrote:
> >
> > —
> > <snip>
> > diff --git a/meta-python/recipes-devtools/python/python-pandas_0.20.3.bb
> <http://python-pandas_0.20.3.bb>
> b/meta-python/recipes-devtools/python/python-pandas_0.20.3.bb
> <http://python-pandas_0.20.3.bb>
> > new file mode 100644
> > index 0000000..f4c486b
> > --- /dev/null
> > +++ b/meta-python/recipes-devtools/python/python-pandas_0.20.3.bb <http://python-pandas_0.20.3.bb>
> > @@ -0,0 +1,10 @@
> > +inherit setuptools
> > +require python-pandas.inc
> > +
> > +RDEPENDS_${PN} += " \
> > + ${PYTHON_PN}-json \
> > + ${PYTHON_PN}-importlib \
> > + "
> > +
> > +SRC_URI[md5sum] = "4df858f28b4bf4fa07d9fbb7f2568173"
> > +SRC_URI[sha256sum] = “a777e07633d83d546c55706420179551c8e01075b53c497dcf8ae4036766bc66"
>
> These SRC_URI checksum lines should go in the python-pandas.inc
> file, rather than duplicate them in both the python-pandas and
> python3-pandas files.
>
> It is quite common now for the “version specific” files to only be
> the “inherit” line and the “require foo.inc” line.
>
> DRY and KISS.
>
> > diff --git
> a/meta-python/recipes-devtools/python/python3-pandas_0.20.3.bb
> <http://python3-pandas_0.20.3.bb>
> b/meta-python/recipes-devtools/python/python3-pandas_0.20.3.bb
> <http://python3-pandas_0.20.3.bb>
> > new file mode 100644
> > index 0000000..81dd360
> > --- /dev/null
> > +++
> b/meta-python/recipes-devtools/python/python3-pandas_0.20.3.bb
> <http://python3-pandas_0.20.3.bb>
> > @@ -0,0 +1,5 @@
> > +inherit setuptools3
> > +require python-pandas.inc
> > +
> > +SRC_URI[md5sum] = "4df858f28b4bf4fa07d9fbb7f2568173"
> > +SRC_URI[sha256sum] =
> "a777e07633d83d546c55706420179551c8e01075b53c497dcf8ae4036766bc66"
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel at lists.openembedded.org
> <mailto:Openembedded-devel at lists.openembedded.org>
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> <http://lists.openembedded.org/mailman/listinfo/openembedded-devel>
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> <mailto:Openembedded-devel at lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> <http://lists.openembedded.org/mailman/listinfo/openembedded-devel>
>
>
More information about the Openembedded-devel
mailing list