[oe] [meta-oe][PATCH] mraa/upm: enable nodejs bindings by default

[Martin Jansa]

Breaks qemuarm builds:

NOTE: Resolving any missing task queue dependencies
ERROR: Nothing RPROVIDES 'nodejs' (but
/home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-extended/mraa/mraa_git.bb,
/home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-extended/upm/upm_git.bb
RDEPENDS on or otherwise requires it)
nodejs was skipped: incompatible with machine qemuarm (not in
COMPATIBLE_MACHINE)
NOTE: Runtime target 'nodejs' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['nodejs']
NOTE: Runtime target 'upm-dev' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['upm-dev', 'mraa', 'nodejs']
NOTE: Runtime target 'upm' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['upm', 'mraa', 'nodejs']
NOTE: Runtime target 'mraa' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['mraa', 'nodejs']
ERROR: Nothing RPROVIDES 'mraa-dev' (but
/home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-extended/mraa/mraa_git.bb
RDEPENDS on or otherwise requires it)
No eligible RPROVIDERs exist for 'mraa-dev'
NOTE: Runtime target 'mraa-dev' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['mraa-dev']



On Wed, Oct 11, 2017 at 9:35 AM, Mikko Ylinen <mikko.ylinen at linux.intel.com>
wrote:

> HAVE_NODEJS is a leftover from meta-refkit-core where the
> layer had to adapt to different BBLAYER combinations (some
> where nodejs wasn't available but mraa/upm were).
>
> Since that check is no longer needed and nodejs is in fact
> part of meta-oe, nodejs bindings can be enabled by default.
>
> Signed-off-by: Mikko Ylinen <mikko.ylinen at linux.intel.com>
> ---
>  meta-oe/recipes-extended/mraa/mraa_git.bb | 2 +-
>  meta-oe/recipes-extended/upm/upm_git.bb   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-oe/recipes-extended/mraa/mraa_git.bb
> b/meta-oe/recipes-extended/mraa/mraa_git.bb
> index 616048fac..56557cca8 100644
> --- a/meta-oe/recipes-extended/mraa/mraa_git.bb
> +++ b/meta-oe/recipes-extended/mraa/mraa_git.bb
> @@ -31,7 +31,7 @@ FILES_${PN}-utils = "${bindir}/"
>  # override this in local.conf to get needed bindings.
>  # BINDINGS_pn-mraa="python"
>  # will result in only the python bindings being built/packaged.
> -BINDINGS ??= "python ${@ 'nodejs' if oe.types.boolean(d.getVar('HAVE_NODEJS')
> or '0') else '' }"
> +BINDINGS ??= "python nodejs"
>
>  PACKAGECONFIG ??= "${@bb.utils.contains('PACKAGES', 'node-${PN}',
> 'nodejs', '', d)} \
>   ${@bb.utils.contains('PACKAGES', '${PYTHON_PN}-${PN}', 'python', '',
> d)}"
> diff --git a/meta-oe/recipes-extended/upm/upm_git.bb
> b/meta-oe/recipes-extended/upm/upm_git.bb
> index 38065ce53..a258ac8b2 100644
> --- a/meta-oe/recipes-extended/upm/upm_git.bb
> +++ b/meta-oe/recipes-extended/upm/upm_git.bb
> @@ -26,7 +26,7 @@ inherit distutils3-base cmake
>  # override this in local.conf to get needed bindings.
>  # BINDINGS_pn-upm="python"
>  # will result in only the python bindings being built/packaged.
> -BINDINGS ??= "python ${@ 'nodejs' if oe.types.boolean(d.getVar('HAVE_NODEJS')
> or '0') else '' }"
> +BINDINGS ??= "python nodejs"
>
>  PACKAGECONFIG ??= "${@bb.utils.contains('PACKAGES', 'node-${PN}',
> 'nodejs', '', d)} \
>   ${@bb.utils.contains('PACKAGES', '${PYTHON_PN}-${PN}', 'python', '',
> d)}"
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>