[oe] [meta-networking][PATCH] arptables: Fix do_install task

Fabio Berton fabio.berton at ossystems.com.br
Tue Oct 31 11:24:16 UTC 2017


Hi Khem,

do_compile task uses these EXTRA_OEMAKE variables too.

On Mon, Oct 30, 2017 at 9:18 PM, Khem Raj <raj.khem at gmail.com> wrote:

> On Mon, Oct 30, 2017 at 10:32 AM, Fabio Berton
> <fabio.berton at ossystems.com.br> wrote:
> > We need to set DESTDIR variable and run eo_runmake install to install all
>                                                                         ^^
> typo
>
> > arptables files. Without this the only file installed in package is
> > systemd unit.
> >
> > Signed-off-by: Fabio Berton <fabio.berton at ossystems.com.br>
> > ---
> >  meta-networking/recipes-support/arptables/arptables_git.bb | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-networking/recipes-support/arptables/arptables_git.bb
> b/meta-networking/recipes-support/arptables/arptables_git.bb
> > index 274a55d91..55903e450 100644
> > --- a/meta-networking/recipes-support/arptables/arptables_git.bb
> > +++ b/meta-networking/recipes-support/arptables/arptables_git.bb
> > @@ -21,9 +21,10 @@ SYSTEMD_SERVICE_${PN} = "arptables.service"
> >
> >  inherit systemd
> >
> > -EXTRA_OEMAKE = "'BINDIR=${sbindir}' 'MANDIR=${mandir}'"
> > +EXTRA_OEMAKE += "'DESTDIR=${D}' 'BINDIR=${sbindir}' 'MANDIR=${mandir}'"
> >
>
> if its needed just during install then we could pass it directly in
> oe_runmake in do_install below
>
> > -do_install_append() {
> > +do_install() {
> > +    oe_runmake install
> >      if ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'true',
> 'false', d)}; then
> >          install -d ${D}${systemd_unitdir}/system
> >          install -m 644 ${WORKDIR}/arptables.service
> ${D}${systemd_unitdir}/system
> > --
> > 2.14.2
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>



More information about the Openembedded-devel mailing list