[oe] [PATCH 19/31] glade3: Move PACKAGECONFIG setting to enable_gnome.conf

[Mark Hatle]

On 9/7/17 4:29 AM, Andreas Müller wrote:
> On Wed, Sep 6, 2017 at 9:23 PM, Mark Hatle <mark.hatle at windriver.com> wrote:
>> This resolves a failure of the yocto-compat-layer.py script.  Changing the
>> PACKAGECONFIG setting by just including a layer can cause problems.
>>
>> Signed-off-by: Mark Hatle <mark.hatle at windriver.com>
>> ---
>>  meta-gnome/conf/enable_gnome.conf                   | 2 ++
>>  meta-gnome/recipes-devtools/glade/glade3_%.bbappend | 1 -
>>  2 files changed, 2 insertions(+), 1 deletion(-)
>>  delete mode 100644 meta-gnome/recipes-devtools/glade/glade3_%.bbappend
>>
>> diff --git a/meta-gnome/conf/enable_gnome.conf b/meta-gnome/conf/enable_gnome.conf
>> index 883a6f5..7e711ee 100644
>> --- a/meta-gnome/conf/enable_gnome.conf
>> +++ b/meta-gnome/conf/enable_gnome.conf
>> @@ -1 +1,3 @@
>>  AVAHI_GTK_pn-avahi-ui = "gtk gtk3"
>> +
>> +PACKAGECONFIG_pn-glade3 = "gnome"
>> diff --git a/meta-gnome/recipes-devtools/glade/glade3_%.bbappend b/meta-gnome/recipes-devtools/glade/glade3_%.bbappend
>> deleted file mode 100644
>> index 3abacfb..0000000
>> --- a/meta-gnome/recipes-devtools/glade/glade3_%.bbappend
>> +++ /dev/null
>> @@ -1 +0,0 @@
>> -PACKAGECONFIG ??= "gnome"
>> --
>> 1.8.3.1
>>
> Yet another stupid question (yes I need gnome support for working with
> glade3): How is enable_gnome.conf supposed to be activated?
> 
> For the record: This is yet another patch kicking things off for the
> sake of yocto-compat-layer script. Is meta-gnome supposed to be yocto
> compatible? Was this decided by 'community'?

See the cover letter:

[18/31] enable_gnome.conf: Move the AVAHI_GTK setting
- The yp-compat script does not allow a layer to modify the system wide
configuration (including modifying other recipe behavior).  The AVHAI_GTK
changes the behavior of that recipe, which is detected by the script.  So
I choose to move this to a configuration file that will need to be required
by the user IF they want avahi to use GTK.  I'm not happy with this, but I
don't see any other way to meet the requirements.

[19/31] glade3: Move PACKAGECONFIG setting to enable_gnome.conf
- Similar to the above, but with PACKAGECONFIG this time.

I don't see an alternative here due to this requirement.  As I said before you
guys maintain meta-openembedded, I don't.  If this doesn't work (and I never
expected it to) then reject the patch and don't merge it.

I simply don't have an answer to any other way to implement this based on the
specific requirement of that checking script.

> But I am sure I missed another point...
> 
> Andreas
>