[oe] [meta-multimedia][PATCH v3 2/2] gerbera: clean recipe

[Martin Jansa]

There as also comment from Khem asking if all these runtime dependencies
are really needed. They should be added automatically by package.bbclass.

And you have libupnp in RDEPENDS. So drop whole RDEPENDS and after build
you can check buildhistory that the runtime dependencies are still there
for whatever is gerbera linked with.

On Wed, Sep 13, 2017 at 5:58 PM, Fabien Lahoudere <
fabien.lahoudere at collabora.co.uk> wrote:

> Clean the recipe and change the name of libupnp to libupnp1.8.
>
> Signed-off-by: Fabien Lahoudere <fabien.lahoudere at collabora.co.uk>
> ---
>  meta-multimedia/recipes-multimedia/gerbera/gerbera_git.bb | 12
> ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/meta-multimedia/recipes-multimedia/gerbera/gerbera_git.bb
> b/meta-multimedia/recipes-multimedia/gerbera/gerbera_git.bb
> index 2bbedc0d1..151127768 100644
> --- a/meta-multimedia/recipes-multimedia/gerbera/gerbera_git.bb
> +++ b/meta-multimedia/recipes-multimedia/gerbera/gerbera_git.bb
> @@ -6,22 +6,22 @@ LIC_FILES_CHKSUM = "file://LICENSE.md;md5=
> 25cdec9afe3f1f26212ead6bd2f7fac8"
>  SRC_URI = "git://github.com/v00d00/gerbera.git;protocol=https \
>            file://gerbera.service "
>
> -
> -# Modify these as desired
>  PV = "1.0+git${SRCPV}"
>  SRCREV = "4435b165d121195aefd67d0287f7f9349e181d45"
>
>  S = "${WORKDIR}/git"
>
> -DEPENDS = "expat zlib curl libupnp e2fsprogs sqlite3 taglib "
> -RDEPENDS_${PN} = "expat zlib curl libupnp e2fsprogs taglib "
> +DEPENDS = "expat zlib curl libupnp1.8 e2fsprogs sqlite3 "
> +RDEPENDS_${PN} = "expat zlib curl libupnp e2fsprogs "
>
>  SYSTEMD_SERVICE_${PN} = "gerbera.service"
> -SYSTEMD_AUTO_ENABLE = "enable"
>
>  inherit cmake systemd
>
> -EXTRA_OECMAKE = "-DWITH_JS=FALSE -DWITH_TAGLIB=FALSE -DWITH_MAGIC=FALSE
> -DWITH_EXIF=FALSE -DLIBUUID_INCLUDE_DIRS=${WORKDIR}/recipe-sysroot/usr/include
> -DLIBUUID_LIBRARIES=-luuid"
> +PACKAGECONFIG = ""
> +PACKAGECONFIG[taglib] = "-DWITH_TAGLIB=TRUE,-DWITH_TAGLIB=FALSE,taglib"
> +
> +EXTRA_OECMAKE = "-DWITH_JS=FALSE -DWITH_MAGIC=FALSE -DWITH_EXIF=FALSE
> -DLIBUUID_INCLUDE_DIRS=${STAGING_INCDIR} -DLIBUUID_LIBRARIES=-luuid"
>
>  do_install_append() {
>         install -d ${D}/root/.config/
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>