[oe] [meta-qt5][PATCH] qt5: add missing commercial license

Christian Gagneraud chgans at gmail.com
Thu Sep 21 10:00:19 UTC 2017


On 21 September 2017 at 14:40, Kwangsub Kim <kwangsub.kim at qt.io> wrote:
[...]
> diff --git a/recipes-qt/qt5/qtserialport_git.bb b/recipes-qt/qt5/qtserialport_git.bb
> index 056e237..23f03ce 100644
> --- a/recipes-qt/qt5/qtserialport_git.bb
> +++ b/recipes-qt/qt5/qtserialport_git.bb
> @@ -3,7 +3,7 @@ require qt5-git.inc
>
>  # text of LGPL_EXCEPTION.txt and LICENSE.FDL is slightly different than what
>  # other qt* components use :/
> -LICENSE = "GFDL-1.3 & BSD & (LGPL-2.1 & The-Qt-Company-Qt-LGPL-Exception-1.1 | LGPL-3.0)"
> +LICENSE = "GFDL-1.3 & BSD & (LGPL-2.1 & The-Qt-Company-Qt-LGPL-Exception-1.1 | LGPL-3.0) | The-Qt-Company-Commercial"

Explicit brackets would be nice to disambiguate & and | precedence.

are we talking, eg:

(LGPL-2.1 & The-Qt-Company-Qt-LGPL-Exception-1.1) | LGPL-3.0

or

GFDL-1.3 & (BSD & (LGPL-2.1 & (The-Qt-Company-Qt-LGPL-Exception-1.1 |
LGPL-3.0)) | The-Qt-Company-Commercial)

whatever the answer is, more explicit bracketing would make it more
obvious to tedious readers, but maybe at the expense of readability
(if that makes sense).

I don't know which part of the code is in charge of evaluating these
expressions, is it eg.:
http://en.cppreference.com/w/cpp/language/operator_precedence,
https://docs.python.org/3/reference/expressions.html#operator-precedence,
or bitbake own sauce....

I think licensing is important to get right, clear and reliable.

Chris



More information about the Openembedded-devel mailing list