[oe] [meta-mono][PATCH] libgdiplus: include name in downloaded file

[Bach, Pascal]

Thanks Ross

That’s even better. I will submit a v2 patch using the new URL.

Pascal

From: Burton, Ross [mailto:ross.burton at intel.com]
Sent: Freitag, 29. September 2017 17:04
To: Bach, Pascal (BT CPS R&D ZG FW CCP) <pascal.bach at siemens.com>
Cc: OpenEmbedded Devel List <openembedded-devel at lists.openembedded.org>
Subject: Re: [oe] [meta-mono][PATCH] libgdiplus: include name in downloaded file

FYI, github.com<http://github.com> /archive/ URLs result in tarballs that can and do change over time, so it's recommended to use either explicitly uploaded tarballs generated by the maintainer, or a git clone.

The github repo doesn't host any maintainer-generated tarballs but luckily the Mono project itself does: https://download.mono-project.com/sources/libgdiplus/.  I'd heavily recommend changing to use those tarballs instead of the /archive/ tarballs.

Ross

On 29 September 2017 at 15:54, Pascal Bach <pascal.bach at siemens.com<mailto:pascal.bach at siemens.com>> wrote:
Without this change the file is named ${PV}.tar.gz

Signed-off-by: Pascal Bach <pascal.bach at siemens.com<mailto:pascal.bach at siemens.com>>
---
 recipes-mono/libgdiplus/libgdiplus-native_4.2.bb<http://libgdiplus-native_4.2.bb> | 3 +--
 recipes-mono/libgdiplus/libgdiplus_4.2.bb<http://libgdiplus_4.2.bb>        | 6 +++---
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/recipes-mono/libgdiplus/libgdiplus-native_4.2.bb<http://libgdiplus-native_4.2.bb> b/recipes-mono/libgdiplus/libgdiplus-native_4.2.bb<http://libgdiplus-native_4.2.bb>
index 4dee6a0..d3a988e 100644
--- a/recipes-mono/libgdiplus/libgdiplus-native_4.2.bb<http://libgdiplus-native_4.2.bb>
+++ b/recipes-mono/libgdiplus/libgdiplus-native_4.2.bb<http://libgdiplus-native_4.2.bb>
@@ -6,8 +6,7 @@ SECTION = "libs"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://COPYING;md5=fe7364dfce9f3689eb6995e7cdd56879<file:///\\COPYING;md5=fe7364dfce9f3689eb6995e7cdd56879>"

-SRC_URI = "https://github.com/mono/libgdiplus/archive/${PV}.tar.gz<https://github.com/mono/libgdiplus/archive/$%7bPV%7d.tar.gz> \
-       "
+SRC_URI = "https://github.com/mono/libgdiplus/archive/${PV}.tar.gz;downloadfilename=libgdiplus-${PV}.tar.gz<https://github.com/mono/libgdiplus/archive/$%7bPV%7d.tar.gz;downloadfilename=libgdiplus-$%7bPV%7d.tar.gz>"

 inherit autotools pkgconfig native

diff --git a/recipes-mono/libgdiplus/libgdiplus_4.2.bb<http://libgdiplus_4.2.bb> b/recipes-mono/libgdiplus/libgdiplus_4.2.bb<http://libgdiplus_4.2.bb>
index 00eb406..03d87f7 100644
--- a/recipes-mono/libgdiplus/libgdiplus_4.2.bb<http://libgdiplus_4.2.bb>
+++ b/recipes-mono/libgdiplus/libgdiplus_4.2.bb<http://libgdiplus_4.2.bb>
@@ -12,9 +12,9 @@ PACKAGECONFIG[tiff] = "--with-libtiff,--without-libtiff,tiff"
 PACKAGECONFIG[gif] = "--with-libgif,--without-libgif,giflib"
 PACKAGECONFIG[exif] = "--with-libexif,--without-libexif,libexif"

-SRC_URI = "https://github.com/mono/libgdiplus/archive/${PV}.tar.gz<https://github.com/mono/libgdiplus/archive/$%7bPV%7d.tar.gz> \
-          file://01-remove-libjpeg-path.patch \
-       "
+SRC_URI = "https://github.com/mono/libgdiplus/archive/${PV}.tar.gz;downloadfilename=libgdiplus-${PV}.tar.gz<https://github.com/mono/libgdiplus/archive/$%7bPV%7d.tar.gz;downloadfilename=libgdiplus-$%7bPV%7d.tar.gz> \
+           file://01-remove-libjpeg-path.patch \
+          "

 inherit autotools pkgconfig

--
2.1.4

--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel at lists.openembedded.org<mailto:Openembedded-devel at lists.openembedded.org>
http://lists.openembedded.org/mailman/listinfo/openembedded-devel