[oe] [meta-qt5][PATCH V2 2/2] qtwebkit: Fix build on armv7ve (rpi)

[Andreas Müller]

On Wed, Apr 4, 2018 at 10:25 PM, Andreas Müller <schnitzeltony at gmail.com> wrote:
> On Wed, Apr 4, 2018 at 9:10 PM, Khem Raj <raj.khem at gmail.com> wrote:
>> Signed-off-by: Khem Raj <raj.khem at gmail.com>
>> ---
>> v1 -> v2:
>> - Drop disabling GI
>>
>>  recipes-qt/qt5/qtwebkit_git.bb | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/recipes-qt/qt5/qtwebkit_git.bb b/recipes-qt/qt5/qtwebkit_git.bb
>> index e8c0868..c8e8328 100644
>> --- a/recipes-qt/qt5/qtwebkit_git.bb
>> +++ b/recipes-qt/qt5/qtwebkit_git.bb
>> @@ -18,6 +18,14 @@ DEPENDS += "qtbase qtdeclarative icu ruby-native sqlite3 glib-2.0 libxslt gperf-
>>  ARM_INSTRUCTION_SET_armv4 = "arm"
>>  ARM_INSTRUCTION_SET_armv5 = "arm"
>>
>> +# https://bugzilla.yoctoproject.org/show_bug.cgi?id=9474
>> +# https://bugs.webkit.org/show_bug.cgi?id=159880
>> +# JSC JIT can build on ARMv7 with -marm, but doesn't work on runtime.
>> +# Upstream only tests regularly the JSC JIT on ARMv7 with Thumb2 (-mthumb).
>> +ARM_INSTRUCTION_SET_armv7a = "thumb"
>> +ARM_INSTRUCTION_SET_armv7r = "thumb"
>> +ARM_INSTRUCTION_SET_armv7ve = "thumb"
>> +
>>  # Patches from https://github.com/meta-qt5/qtwebkit/commits/b5.10
>>  # 5.10.meta-qt5.1
>>  SRC_URI += "\
>> --
>> 2.16.3
>>
> I've checked the links you are referring: Both
>
> * are related to webkit and from 2016
> * deal with runtime errors not build errors as referred in patch description.
>
> So what do you want to fix exactly?
>
I have looked into this further and found that I stumbled for same

commit 511a3764506ce6bbdc5e9441a8f4e9d862ea1102
Author: Andreas Müller <schnitzeltony at googlemail.com>
Date:   Mon Jan 4 11:04:16 2016 +0100

    qtscript/qtwebkit: disable thumb for armv4 and armv5 only to fix
segfault on armv7

Curently recipe has

ARM_INSTRUCTION_SET_armv4 = "arm"
ARM_INSTRUCTION_SET_armv5 = "arm"

Isn't thumb default any more?

Andreas