[oe] [meta-networking][PATCH] rdma-core: add new recipe

[Wei Lin Guay]

Hi Khem Raj,

Thanks for your prompt review/response!

On 04/24/2018 06:46 PM, Khem Raj wrote:
> On Tue, Apr 24, 2018 at 2:13 AM, Wei Lin Guay <wguay at graphcore.ai> wrote:
>> RDMA core is the userspace components for the Linux Kernel's
>> InfiniBand/RoCE subsystem. This component contains the userspace
>> libraries for libibverbs (and its associated providers libraries),
>> librdmacm and libibumad. Besides, it also provides additional service
>> daemons such as ibacm and srp_daemon.
>>
>> Signed-off-by: Wei Lin Guay <wguay at graphcore.ai>
>> Reviewed-by: Harald Høeg <hhoeg at graphcore.ai>
>> ---
>>   .../recipes-support/rdma-core/rdma-core_17.bb      | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>   create mode 100644 meta-networking/recipes-support/rdma-core/rdma-core_17.bb
>>
>> diff --git a/meta-networking/recipes-support/rdma-core/rdma-core_17.bb b/meta-networking/recipes-support/rdma-core/rdma-core_17.bb
>> new file mode 100644
>> index 0000000..e45262a
>> --- /dev/null
>> +++ b/meta-networking/recipes-support/rdma-core/rdma-core_17.bb
>> @@ -0,0 +1,22 @@
>> +SUMMARY = "Userspace support for InfiniBand/RDMA verbs"
>> +DESCRIPTION = "This is the userspace components for the Linux Kernel's drivers Infiniband/RDMA subsystem."
>> +SECTION = "libs"
>> +
>> +DEPENDS = "libnl eudev"
> is eudev a must ?

It isn't, I will fix in v2.

>
>> +RDEPENDS_${PN} = "bash perl"
>> +
>> +SRC_URI = "git://github.com/linux-rdma/rdma-core.git;protocol=http;rev=v${PV}"
> Drop rev pointing to a tag. We need a hardcoded SHA
>
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +LICENSE = "BSD"
> it seems there are GPL-2.0 and MIT in play as well also this seems
> more like BSD-2-Clause so
> please make it specific.

Thanks and noted. I will fix both comments above (change the LICENCE and remove the tag) in v2.

Thanks,
Wei Lin

>
>> +LIC_FILES_CHKSUM = "file://COPYING.BSD_MIT;md5=4cef3f976a07850eb6d2e5d1ef945e6b"
>> +
>> +
>> +FILES_SOLIBSDEV = ""
>> +FILES_${PN} += "${libdir}/*"
>> +INSANE_SKIP_${PN} += "dev-so"
>> +
>> +inherit cmake
>> +
>> +OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM = "BOTH"
>> --
>> 2.9.3
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel