[oe] [OE-core] [meta-oe][PATCH] directfb: fix tslib version check in configure.in

[Jonas Mark (BT-FIR/ENG1)]

Hi Richard,

I already sent an updated version of the patch to the
openembedded-devel at lists.openembedded.org mailing list. An automatic
system informed me that I hit the wrong mailing list. I am now
intentionally cross-posting this reply to both lists. Hopefully, further
discussions will only take place at openembedded-devel.

[meta-oe,v2] directfb: fix tslib version check in configure.in
https://patchwork.openembedded.org/patch/153470/

> > From: Guan Ben <ben.guan at cn.bosch.com>
> >
> > The patch makes sure that the old as well as the new tslib pkg-config
> > metadata file naming style is handled correctly.
> >
> > tslib 0.0 to 1.0 created only a tslib-<VERSION>.pc pkg-config
> > metadata
> > file.
> >
> > With tslib 1.1 the tslib-<VERSION>.pc phase out was started.
> > Additionally, the pkg-config metadata file tslib.pc was added.
> >
> > Since tslib 1.6 the tslib-<VERSION>.pc metadata file is deprecated.
> > Now, there is only a tslib.pc.

In the beginning tslib only had a tslib-<VERSION>.pc for pkgconfig.

Starting with tslib 1.1, tslib.pc and tslib-<VERSION>.pc were created
for pkgconfig. And the tslib-<VERSION>.pc file was declared to be
deprecated.

From tslib 1.6 on only the tslib.pc file is available.

DirectFB's configure.in is not aware that there is a situation without
a tslib-<VERSION>.pc file. Thus it will not find tslib and this causes
that the tslib input driver won't be built.

DirectFB 1.7.7:

enable_tslib=no
if test "$checkfor_tslib" = "yes"; then
  PKG_CHECK_MODULES([TSLIB], [tslib-1.0 >= 1.0.0], [enable_tslib=yes], [enable_tslib=no])
  if test "$enable_tslib" = "no"; then
     PKG_CHECK_MODULES([TSLIB], [tslib-0.0], [enable_tslib=yes], [enable_tslib=no
       AC_MSG_WARN([*** no tslib -- tslib driver will not be built.])])
  fi
fi


Patched:

enable_tslib=no
if test "$checkfor_tslib" = "yes"; then
  PKG_CHECK_MODULES([TSLIB], [tslib >= 1.1], [enable_tslib=yes], [enable_tslib=no])
  if test "$enable_tslib" = "no"; then
    PKG_CHECK_MODULES([TSLIB], [tslib-1.0 >= 1.0], [enable_tslib=yes], [enable_tslib=no])
    if test "$enable_tslib" = "no"; then
      PKG_CHECK_MODULES([TSLIB], [tslib-0.0], [enable_tslib=yes], [enable_tslib=no
        AC_MSG_WARN([*** no tslib -- tslib driver will not be built.])])
    fi
  fi
fi

Greetings,
Mark

Building Technologies, Panel Software Fire (BT-FIR/ENG1) 
Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com

Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118 
Aufsichtsratsvorsitzender: Stefan Hartung; Geschäftsführung: Tanja Rückert, Andreas Bartz, Thomas Quante, Bernhard Schuster