[oe] [meta-java][PATCH 6/9] openjdk-8: gcc-8 fix #2: silence build warnings/errors (return-type)

[Richard Leitner]

Hi André,
just some nitpicking:

On 8/13/18 12:09 PM, André Draszik wrote:
> From: André Draszik <andre.draszik at jci.com>
> 
> Similar to the patch just reverted, we wilence the build warnings
> regarding return type of functions, but we only do this for gcc versions
> where it matters, now that our infrastructure for doing so works again:

I guess with "the patch just reverted" you refer to the [PATCH 7/9] which will be applied afterwards.

Is it OK for you if I apply Patch #7 before Patch #6 so the commit message works out?

Furthermore I'll change "wilence" to "silence" if it's OK for you? ;-)

> 
>     | <<PKGBUILDDIR>>/hotspot/src/share/vm/utilities/globalDefinitions_gcc.hpp:223:32: error: control reaches end of non-void function [-Werror=return-type]
>     |  #define BREAKPOINT ::breakpoint()
>     |                     ~~~~~~~~~~~~^~
>     | <<PKGBUILDDIR>>/hotspot/src/share/vm/utilities/debug.hpp:192:3: note: in expansion of macro 'BREAKPOINT'
>     |    BREAKPOINT;                                                                \
>     |    ^~~~~~~~~~
>     | <<PKGBUILDDIR>>/hotspot/src/cpu/aarch64/vm/c1_LIRAssembler_aarch64.cpp:197:2: note: in expansion of macro 'ShouldNotReachHere'
>     |   ShouldNotReachHere();
>     |   ^~~~~~~~~~~~~~~~~~
>     etc.
> 
> Signed-off-by: André Draszik <andre.draszik at jci.com>
> ---
>  recipes-core/openjdk/openjdk-8-common.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/recipes-core/openjdk/openjdk-8-common.inc b/recipes-core/openjdk/openjdk-8-common.inc
> index fb97e97..77d905d 100644
> --- a/recipes-core/openjdk/openjdk-8-common.inc
> +++ b/recipes-core/openjdk/openjdk-8-common.inc
> @@ -216,6 +216,7 @@ EXTRA_OECONF_append = "\
>  # of these changes.
>  FLAGS_GCC6 = "-fno-lifetime-dse -fno-delete-null-pointer-checks"
>  FLAGS_GCC7 = "-fno-lifetime-dse -fno-delete-null-pointer-checks"
> +FLAGS_GCC8 = "-Wno-error=return-type"
>  
>  # All supported cross compilers support the compiler flags that were
>  # added to make compilation with gcc6 work. But the host compiler for
> 

regards;Richard.L