[oe] [meta-java][PATCH] dbus-java: Do not build any documentation

[Yevgeny Popovych]

Hi Richard,

Thank you, please find my answers below.
If you are going to accept this, can you consider also applying to sumo?


On 08/14/2018 09:56 AM, Richard Leitner wrote:
> Hi Yevgeny,
> thank you for your patch.
> 
> Please find my comments below.
> 
> On 8/13/18 6:49 PM, Yevgeny Popovych wrote:
>> Support for respective docbook tools has been removed in pyro release.
> 
> Do you have any reference for that?
> It would be great if you could include it here.

Yes, it was removed by commit 4814d93646f6b86aaffbd3fca1af29c8c577db5b
in openembedded-core, which is included since pyro release.

> 
> Is there no alternative to removing the manpages?

Nothing I can think of.. and it's probably not a huge loss.
For instance, before removing SGML stack Alexander Kanavin 
removed man pages for iputils (58ac4da13cf32e1c8484d1a6ac51f0f439a6932c).

> 
>>
>> Signed-off-by: Yevgeny Popovych <yevgenyp at pointgrab.com>
>> Cc: Henning Heinold <henning at itconsulting-heinold.de>
>> Cc: Maxin John <maxin.john at intel.com>
>> Cc: Otavio Salvador <otavio at ossystems.com.br>
>> Cc: Richard Leitner <richard.leitner at skidata.com>
>> ---
>>  recipes-extended/dbus/dbus-java_2.7.bb | 22 ++--------------------
>>  1 file changed, 2 insertions(+), 20 deletions(-)
>>
>> diff --git a/recipes-extended/dbus/dbus-java_2.7.bb b/recipes-extended/dbus/dbus-java_2.7.bb
>> index 4964cf8..0b093a0 100644
>> --- a/recipes-extended/dbus/dbus-java_2.7.bb
>> +++ b/recipes-extended/dbus/dbus-java_2.7.bb
>> @@ -6,7 +6,7 @@ HOMEPAGE = "http://dbus.freedesktop.org/doc/dbus-java"
>>  SECTION = "libs"
>>  LICENSE = "LGPL-2.1 & AFL-2.1"
>>  
>> -DEPENDS = "libmatthew docbook-utils-native docbook-sgml-dtd-4.1-native fastjar-native"
>> +DEPENDS = "libmatthew gettext-native fastjar-native"
>>  RDEPENDS_${PN}-viewer = "java2-runtime libunixsocket-java ${PN}-bin libmatthew-debug-java ${JPN}"
>>  RDEPENDS_${PN}-bin = "java2-runtime libunixsocket-java libmatthew-debug-java ${JPN}"
>>  RSUGGESTS_${JPN} = "libunixsocket-java"
>> @@ -49,15 +49,6 @@ do_compile () {
>>  		JAVAUNIXJARDIR=${datadir_java} \
>>  		JAVAUNIXLIBDIR=${libdir_jni} \
>>  		bin
>> -
>> -	# Generate man pages.
>> -	oe_runmake \
>> -		JAVAC="oefatal \"No Java compilation expected here.\"" \
>> -		JAR="oefatal \"No jar invocation expected here.\"" \
>> -		JARPREFIX=${datadir_java} \
>> -		JAVAUNIXJARDIR=${datadir_java} \
>> -		JAVAUNIXLIBDIR=${libdir_jni} \
>> -		man
>>  }
>>  
>>  JARFILENAME = "${JPN}-${PV}.jar"
>> @@ -73,20 +64,11 @@ do_install () {
>>    install bin/CreateInterface ${D}${bindir}
>>    install bin/ListDBus ${D}${bindir}
>>    install bin/DBusDaemon ${D}${bindir}
>> -
>> -	oe_runmake \
>> -		JAVAC="oefatal \"No Java compilation expected here.\"" \
>> -		JAR="oefatal \"No jar invocation expected here.\"" \
>> -		MANPREFIX=${D}${mandir} \
>> -		DOCPREFIX=${D}${docdir}/${JPN} \
>> -		install-man
>>  }
>>  
>>  # ${JPN} must be last otherwise it would pick up dbus-viewer*.jar
>>  # and dbus-bin*.jar
>> -PACKAGES = "${PN}-viewer ${PN}-viewer-doc ${PN}-bin ${PN}-bin-doc ${JPN}"
>> +PACKAGES = "${PN}-viewer ${PN}-bin ${JPN}"
>>  
>>  FILES_${PN}-viewer = "${datadir}/java/dbus-java-viewer*.jar ${bindir}/DBusViewer"
>> -FILES_${PN}-viewer-doc = "${mandir}/DBusViewer*"
>>  FILES_${PN}-bin = "${datadir}/java/dbus-java-bin*.jar ${bindir}"
>> -FILES_${PN}-bin-doc = "${mandir} ${docdir}/${JPN}"
>>
> 
> regards;Richard.L
> 

--
Sincerely,
Yevgeny Popovych