[oe] [meta-oe][morty][PATCH v2] libconfig: fix SRC_URI

[Martin Jansa]

Using git fetcher is fine, but don't use tag parameter nor tagname in
SRCREV, use git SHA which matches the tag in SRCREV.

Otherwise bitbake fetcher will still need to access then network every
single time to map tag name to git SHA used internally.

On Sun, Aug 26, 2018 at 1:34 PM Yi-Soo An <yisooan at gmail.com> wrote:

> Thank you for the email.
>
> I have a question.
>
> Since hyperrealm has moved to github and the library is maintained there.
> Is it better to replace the current SRC_URI with git? as below.
> SRC_URI = "git://github.com/hyperrealm/libconfig.git;tag=v1.5"
> archive seems to need extra information, like checksum.
>
> Best regards,
> Yi-Soo An
>
> On 08/26/2018 03:00 PM, Martin Jansa wrote:
> > Don't use github archives which are regenerated from time to time with
> > different checksum.
> >
> > To fix it in morty all newer release needs to be fixed as well and then
> > the fix backported to morty (or explained in commit message why the fix
> > is needed only for morty).
> >
> > On Sun, Aug 26, 2018 at 7:01 AM Yi-Soo An <yisooan at gmail.com
> > <mailto:yisooan at gmail.com>> wrote:
> >
> >     It causes a fetch error since hyperrealm has moved to github
> >     and the current SRC_URI is not available any longer.
> >
> >     To fix the error, use github repository.
> >
> >     Signed-off-by: Yi-Soo An <yisooan at gmail.com <mailto:
> yisooan at gmail.com>>
> >     ---
> >       meta-oe/recipes-extended/libconfig/libconfig_1.5.bb
> >     <http://libconfig_1.5.bb> | 8 ++++----
> >       1 file changed, 4 insertions(+), 4 deletions(-)
> >
> >     diff --git a/meta-oe/recipes-extended/libconfig/libconfig_1.5.bb
> >     <http://libconfig_1.5.bb>
> >     b/meta-oe/recipes-extended/libconfig/libconfig_1.5.bb
> >     <http://libconfig_1.5.bb>
> >     index fb6e50e51..a0b3a9471 100644
> >     --- a/meta-oe/recipes-extended/libconfig/libconfig_1.5.bb
> >     <http://libconfig_1.5.bb>
> >     +++ b/meta-oe/recipes-extended/libconfig/libconfig_1.5.bb
> >     <http://libconfig_1.5.bb>
> >     @@ -1,14 +1,14 @@
> >       SUMMARY = "C/C++ Configuration File Library"
> >       DESCRIPTION = "Library for manipulating structured configuration
> >     files"
> >     -HOMEPAGE = "http://www.hyperrealm.com/libconfig/"
> >     +HOMEPAGE = "https://hyperrealm.github.io/libconfig"
> >       SECTION = "libs"
> >
> >       LICENSE = "LGPLv2.1"
> >       LIC_FILES_CHKSUM =
> >     "file://COPYING.LIB;md5=fad9b3332be894bab9bc501572864b29"
> >
> >     -SRC_URI = "http://www.hyperrealm.com/${BPN}/${BP}.tar.gz
> >     <http://www.hyperrealm.com/$%7BBPN%7D/$%7BBP%7D.tar.gz>"
> >     +SRC_URI = "
> https://github.com/hyperrealm/libconfig/archive/v1.5.tar.gz"
> >
> >       inherit autotools-brokensep pkgconfig
> >
> >     -SRC_URI[md5sum] = "a939c4990d74e6fc1ee62be05716f633"
> >     -SRC_URI[sha256sum] =
> >     "e31daa390d8e4461c8830512fe2e13ba1a3d6a02a2305a02429eec61e68703f6"
> >     +SRC_URI[md5sum] = "e92a91c2ddf3bf77bea0f5ed7f09e492"
> >     +SRC_URI[sha256sum] =
> >     "cae5c02361d8a9b2bb26946c64f089d2e5e599972f386203fbc48975c0d885c8"
> >     --
> >     2.17.1
> >
> >     --
> >     _______________________________________________
> >     Openembedded-devel mailing list
> >     Openembedded-devel at lists.openembedded.org
> >     <mailto:Openembedded-devel at lists.openembedded.org>
> >     http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
>