[oe] [meta-oe][PATCH] s-suite: push SRCREV to version 3.0

[Paolo Valente]

> Il giorno 13 dic 2018, alle ore 18:18, Khem Raj <raj.khem at gmail.com> ha scritto:
> 
> On Thu, Dec 13, 2018 at 9:16 AM Paolo Valente <paolo.valente at linaro.org> wrote:
>> 
>> 
>> 
>>> Il giorno 13 dic 2018, alle ore 18:11, Khem Raj <raj.khem at gmail.com> ha scritto:
>>> 
>>> On Thu, Dec 13, 2018 at 7:33 AM Paolo Valente <paolo.valente at linaro.org> wrote:
>>>> 
>>>> 
>>>> 
>>>>> Il giorno 13 dic 2018, alle ore 16:27, Khem Raj <raj.khem at gmail.com> ha scritto:
>>>>> 
>>>>> On Thu, Dec 13, 2018 at 7:16 AM Paolo Valente <paolo.valente at linaro.org> wrote:
>>>>>> 
>>>>>> Signed-off-by: Paolo Valente <paolo.valente at linaro.org>
>>>>>> ---
>>>>>> meta-oe/recipes-benchmark/s-suite/s-suite_git.bb | 5 +++--
>>>>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>>>> 
>>>>>> diff --git a/meta-oe/recipes-benchmark/s-suite/s-suite_git.bb b/meta-oe/recipes-benchmark/s-suite/s-suite_git.bb
>>>>>> index 77d172814..166f3000a 100644
>>>>>> --- a/meta-oe/recipes-benchmark/s-suite/s-suite_git.bb
>>>>>> +++ b/meta-oe/recipes-benchmark/s-suite/s-suite_git.bb
>>>>>> @@ -2,7 +2,7 @@ SUMMARY = "Small collection of benchmarks for storage I/O"
>>>>>> LICENSE = "GPLv2"
>>>>>> LIC_FILES_CHKSUM = "file://COPYING;md5=b529aaa6a0c50f15d29f89609b5c22f3"
>>>>>> 
>>>>>> -SRCREV = "79698f645bfb28d0d966484ddad3a1efb562246d"
>>>>>> +SRCREV = "e2727f70ed79b5461689c062a4a66a87f1adb4ce"
>>>>>> PV = "0.0+git${SRCPV}"
>>>>>> SRC_URI = "git://github.com/Algodev-github/S.git;protocol=https;branch=master"
>>>>>> 
>>>>>> @@ -21,7 +21,8 @@ do_install() {
>>>>>>   install -m0755 ${S}/def_config_params.sh ${D}/opt/S-suite
>>>>>> }
>>>>>> 
>>>>>> -RDEPENDS_${PN} = "bash bc coreutils gawk g++ gcc fio libaio libaio-dev sysstat"
>>>>>> +RDEPENDS_${PN} = "bash bc coreutils gawk g++ gcc fio libaio libaio-dev sysstat \
>>>>>> +                 psmisc git"
>>>>> 
>>>>> why these new rdeps
>>>> 
>>>> psmisc is for killall, git is for ... git :)
>>> 
>>> I think busybox provides killall too.
>> 
>> Ok, I'll remove this dep.
>> 
>>>> 
>>>> Some weeks ago, I bumped into this missing dependencies that made the
>>>> automatic execution of a test fail on a system without either killall
>>>> or git.
>>> 
>>> OK. so I wonder if we dont have killall enabled in oe-core by default in
>>> busybox ? or does it need ps-misc one specifically ?
>>> 
>>> git is interesting, does it clone some sources during executing tests ?
>>> 
>> In kernel-task benchmarks a mainline Linux is cloned.  But maybe such
>> benchmarks do not make sense in oe.  Let me know, and I'll remove this
>> dep too.
> 
> they are fine. We just need to understand that they are well meaning changes.
> 

So, is the patch ok, or shall I remove the psmisc dep?

Thanks,
Paolo