[oe] [PATCH] wifi-test-suite: Initial recipe for wifi test suite.

Ankit Navik ankit.tarot at gmail.com
Mon Dec 24 17:01:18 UTC 2018


Hi Schneider,
Thank you for your valuable feedback.

On Sun, Dec 23, 2018 at 9:52 PM Reto Schneider <code at reto-schneider.ch>
wrote:

> On 12/23/18 9:24 AM, Ankit Navik wrote:
> > Add generic recipe for wifi test suite from wifi alliance.
> > Suite is to support certification program development and device
> certification.
>
> I did pretty much the same a few weeks ago [1] for a MIPS/musl based IoT
> gateway [2] (DUT).
>
> What I learned:
>  - You will need some patches for the makefiles [3]
>

You patch got failed when I tried to compile using
bitbake wifi-test-suite -c compile -f
CC ?= gcc --> I think, this is not required.
It is better to use as implicit variable itself.

 - When using musl, you will need something like this (parts of it) [4] too
>  - If you are using the Busybox utils, those scripts will not work an
> need to be adapted. Our Testhouse did do this for us, so I do not know
> exactly what changes where needed.
>
> Let me check this and other comments as well.

Regards, Ankit


> > +do_compile () {
> > +     oe_runmake
> > +}
>
> Pretty sure this is not needed. My recipe at least does have this.
>
> > +do_install () {
> > +     install -d ${D}${libdir}
> > +     install -m 0644 ${S}/lib/libwfa.a ${D}${libdir}
> > +     install -m 0644 ${S}/lib/libwfa_ca.a ${D}${libdir}
> > +     install -m 0644 ${S}/lib/libwfa_dut.a ${D}${libdir}
>
> I do not think that you need the static libraries.
>
> > +     install -d ${D}${sbindir}
> > +     install -m 0755 ${S}/dut/wfa_dut ${D}${sbindir}
> > +     install -m 0755 ${S}/ca/wfa_ca ${D}${sbindir}
> > +     install -m 0755 ${S}/WTGService/WTG ${D}${sbindir}
> > +     install -m 0755 ${S}/console_src/wfa_con ${D}${sbindir}
> > +# Test scripts
> > +     install -m 0644 ${S}/scripts/getipconfig.sh ${D}${sbindir} # Must
> copy
>
> They have hard coded the path to this script [5][6]. You will need to
> fix the installation location or their C code.
>
> > +     install -m 0644 ${S}/scripts/arp_neigh_loop ${D}${sbindir}
> > +     install -m 0644 ${S}/scripts/dev_send_frame ${D}${sbindir}
> > +     install -m 0644 ${S}/scripts/findprocess.sh ${D}${sbindir}
> > +     install -m 0644 ${S}/scripts/getpid.sh ${D}${sbindir}
> > +     install -m 0644 ${S}/scripts/getpstats.sh ${D}${sbindir}
> > +     install -m 0644 ${S}/scripts/gpstats.sh ${D}${sbindir}
> > +     install -m 0644 ${S}/scripts/sta_reset_parm ${D}${sbindir}
> > +     install -m 0644 ${S}/scripts/stoping.sh ${D}${sbindir}
> > +     install -m 0644 ${S}/scripts/updatepid.sh ${D}${sbindir}
> > +     install -m 0644 ${S}/scripts/wfaping6.sh ${D}${sbindir}
> > +     install -m 0644 ${S}/scripts/wfaping.sh ${D}${sbindir}
> > +     install -m 0644 ${S}/scripts/wfa_test_cli.sh ${D}${sbindir}
> > +}
>
> How about "install -m 0755 -D ${S}/scripts/*.sh ${D}${bindir}" for the
> scripts?
>
> [1]
>
> https://github.com/husqvarnagroup/smart-garden-gateway-yocto-meta-gardena/blob/master/recipes-wifi-alliance/wifi-testsuite/wifi-testsuite_git.bb
> [2] https://github.com/husqvarnagroup/smart-garden-gateway-public
> [3] https://github.com/Wi-FiTestSuite/Wi-FiTestSuite-Linux-DUT/pull/42
> [4]
>
> https://github.com/husqvarnagroup/smart-garden-gateway-wifi-alliance-test-suite/compare/eb2799fbc28a2e5b309e2e85d0fa0b8e9cd0d100...master
> [5]
>
> https://github.com/Wi-FiTestSuite/Wi-FiTestSuite-Linux-DUT/blob/master/lib/wfa_cs.c#L322
> [6]
>
> https://github.com/Wi-FiTestSuite/Wi-FiTestSuite-Linux-DUT/blob/master/lib/wfa_cs.c#L2118
>
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>


More information about the Openembedded-devel mailing list