[oe] [meta-oe][PATCH 2/2] samba, openwsman, pam-ssh-agent-auth, sblim-sfcb, passwdqc, python-pam, smbnetfs: require pam in DISTRO_FEATURES

[Martin Jansa]

Hi Andreas,

I'm just trying to get rid of libpam from builds without pam in
DISTRO_FEATURES (even for world builds, see the change for oe-core).

I'm aware that libpam usage from samba is a bit strange as discussed few
times:
http://lists.openembedded.org/pipermail/openembedded-commits/2016-October/198752.html
http://lists.openembedded.org/pipermail/openembedded-devel/2016-March/106583.html
http://lists.openembedded.org/pipermail/openembedded-devel/2016-September/109143.html

Now RSS and also with libpam being available only when pam is in
DISTRO_FEATURES, we might possibly return the PACKAGECONFIG without
re-introducing undeterministic link with libpam, but I'm not using samba
(other than building it in bitbake world) so I'll let that to people who
actually care about samba itself (and can properly test it in runtime).

Regards,

On Thu, Feb 1, 2018 at 4:57 PM, Andreas Oberritter <obi at opendreambox.org>
wrote:

> Hi Martin,
>
> On Thu,  1 Feb 2018 14:23:40 +0000
> Martin Jansa <martin.jansa at gmail.com> wrote:
>
> > * there is explicit dependency on libpam without respecting pam in
> DISTRO_FEATURES
> >   so add the check to prevent people building it against broken libpam
>
> [...]
>
> > --- a/meta-networking/recipes-connectivity/samba/samba_4.7.0.bb
> > +++ b/meta-networking/recipes-connectivity/samba/samba_4.7.0.bb
> > @@ -40,9 +40,10 @@ inherit systemd waf-samba cpan-base perlnative
> update-rc.d
> >  # remove default added RDEPENDS on perl
> >  RDEPENDS_${PN}_remove = "perl"
> >
> > -#DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb
> libtevent libldb libbsd libaio libpam"
> > -DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb
> libtevent libbsd libaio libpam"
> > -DEPENDS += "libldb"
> > +DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb
> libtevent libldb libbsd libaio libpam"
> > +
> > +inherit distro_features_check
> > +REQUIRED_DISTRO_FEATURES = "pam"
>
> AFAIR, Samba doesn't build without libpam, but runs fine without a PAM
> installation. Which problem you're trying to solve? I guess it's fair
> to expect a dysfunctional PAM library without the 'pam' distro feature.
>
> Regards,
> Andreas
>