[oe] [meta-qt5][PATCH v2] qtbase: add a config option to optimize for size

[Kwangsub Kim]

Hi,

Now I got to know the meaning of your response. I had tried to solve the problem with PACKAGECONFIG[optimize-size] only. I will send the updated patch soon.
Thanks for your advice.

Best regards,
Kwangsub

From: Martin Jansa <martin.jansa at gmail.com>
Date: Tuesday, 20 February 2018 at 7:05 PM
To: Kwangsub Kim <kwangsub.kim at qt.io>
Cc: openembedded-devel <openembedded-devel at lists.openembedded.org>
Subject: Re: [oe] [meta-qt5][PATCH v2] qtbase: add a config option to optimize for size

Hi,

that's not what is wrong with this.

What you're doing is:
PACKAGECONFIG[optimize-size] = "-optimize-size,-optimize-size"
when -Os is enabled and
PACKAGECONFIG[optimize-size] = "-optimize-size"
when it isn't but, that's not how PACKAGECONFIG is used by any sane person.


What you should do is to keep:
PACKAGECONFIG[optimize-size] = "-optimize-size"



as it was and add:
${@bb.utils.contains('SELECTED_OPTIMIZATION', '-Os', 'optimize-size', '', d)}

in default PACKAGECONFIG variable (search "PACKAGECONFIG ?= " \", or you can add it to PACKAGECONFIG_DEFAULT variable).


Regards,

On Tue, Feb 20, 2018 at 8:39 AM, Kwangsub Kim <kwangsub.kim at qt.io<mailto:kwangsub.kim at qt.io>> wrote:
Hi Martin,

Thanks for your feedback.
I failed to find a right way to add the inline function. That’s why I added new variable. I tried to update like below but it caused a syntax error. The function (bb.utils.contains) was not evaluated and just copied as a string. Could you kindly advise me to fix this?

PACKAGECONFIG[optimize-size] = "-optimize-size,${@bb.utils.contains('SELECTED_OPTIMIZATION', '-Os', '-optimize-size', '', d)}"

Best regards,
Kwangsub

From: Martin Jansa <martin.jansa at gmail.com<mailto:martin.jansa at gmail.com>>
Date: Monday, 19 February 2018 at 9:07 PM
To: Kwangsub Kim <kwangsub.kim at qt.io<mailto:kwangsub.kim at qt.io>>
Cc: openembedded-devel <openembedded-devel at lists.openembedded.org<mailto:openembedded-devel at lists.openembedded.org>>
Subject: Re: [oe] [meta-qt5][PATCH v2] qtbase: add a config option to optimize for size

This doesn't make sense.

Leave PACKAGECONFIG[optimize-size] as it was in v2 and add ${@bb.utils.contains('SELECTED_OPTIMIZATION', '-Os', 'optimize-size', '', d)} to default PACKAGECONFIG value.


On Mon, Feb 19, 2018 at 9:53 AM, Kwangsub Kim <kwangsub.kim at qt.io<mailto:kwangsub.kim at qt.io>> wrote:
The '-optimize-size' option would enable the compiler to optimize
for size instead of speed. If the global compiler option already
included '-Os', this option would be enabled by default.

It would affect the whole Qt libraries and Qt applications as well.
This feature is available in Qt 5.9+.

Signed-off-by: Kwangsub Kim <kwangsub.kim at qt.io<mailto:kwangsub.kim at qt.io>>
---
 recipes-qt/qt5/qtbase_git.bb<http://qtbase_git.bb> | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/recipes-qt/qt5/qtbase_git.bb<http://qtbase_git.bb> b/recipes-qt/qt5/qtbase_git.bb<http://qtbase_git.bb>
index 4f3ade2..208a755 100644
--- a/recipes-qt/qt5/qtbase_git.bb<http://qtbase_git.bb>
+++ b/recipes-qt/qt5/qtbase_git.bb<http://qtbase_git.bb>
@@ -147,6 +147,9 @@ PACKAGECONFIG[widgets] = "-widgets,-no-widgets"
 PACKAGECONFIG[libproxy] = "-libproxy,-no-libproxy,libproxy"
 PACKAGECONFIG[libinput] = "-libinput,-no-libinput,libinput"
 PACKAGECONFIG[journald] = "-journald,-no-journald,systemd"
+PACKAGECONFIG[optimize-size] = "-optimize-size,${QT_DEFAULT_OPTIMIZATION_FOR_SIZE}"
+
+QT_DEFAULT_OPTIMIZATION_FOR_SIZE = "${@bb.utils.contains('SELECTED_OPTIMIZATION', '-Os', '-optimize-size', '', d)}"

 QT_CONFIG_FLAGS_GOLD = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', '-use-gold-linker', '-no-use-gold-linker', d)}"
 QT_CONFIG_FLAGS += " \
--
2.7.4

--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel at lists.openembedded.org<mailto:Openembedded-devel at lists.openembedded.org>
http://lists.openembedded.org/mailman/listinfo/openembedded-devel