[oe] [meta-networking][PATCHv2] samba: Add packagegroup

[Zheng, Ruoqin]

Hi Andreas:
     I'm sorry I didn't explain it. 
> You didn't answer my question about the dependency on perl:

   Well, the samba-pidl is not required to run the Samba server.

> Instead you removed the server meta package without explanation. It's hard to follow the reasoning behind your patch iterations this way.

   I'm sorry I miss it, in my v3 patch, I will include it like this:
+RDEPENDS_${PN}-server = "\
+    ${PN} \
+    winbind \
+    registry-tools \
+    "

----------------------------------------------------
Zheng Ruoqin
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
ADDR.: No.6 Wenzhu Road, Software Avenue,
       Nanjing, 210012, China
MAIL : zhengrq.fnst at cn.fujistu.com


-----Original Message-----
From: openembedded-devel-bounces at lists.openembedded.org [mailto:openembedded-devel-bounces at lists.openembedded.org] On Behalf Of Andreas Oberritter
Sent: Wednesday, January 24, 2018 8:06 AM
To: openembedded-devel at lists.openembedded.org
Subject: Re: [oe] [meta-networking][PATCHv2] samba: Add packagegroup

On Tue, 23 Jan 2018 07:38:33 +0000
"Zheng, Ruoqin" <zhengrq.fnst at cn.fujitsu.com> wrote:

> ping

You didn't answer my question about the dependency on perl:

http://lists.openembedded.org/pipermail/openembedded-devel/2017-December/115938.html

Instead you removed the server meta package without explanation. It's hard to follow the reasoning behind your patch iterations this way.

Btw, you kept one of the SUMMARY lines, which doesn't contain anything but the package name.

Regards,
Andreas



> 
> --------------------------------------------------
> Zheng Ruoqin
> Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
> ADDR.: No.6 Wenzhu Road, Software Avenue,
>        Nanjing, 210012, China
> MAIL : zhengrq.fnst at cn.fujistu.com
> 
> 
> -----Original Message-----
> From: Zheng, Ruoqin/郑 若钦
> Sent: Monday, December 11, 2017 10:22 PM
> To: openembedded-devel at lists.openembedded.org
> Cc: Zheng, Ruoqin/郑 若钦 <zhengrq.fnst at cn.fujitsu.com>
> Subject: [oe][meta-networking][PATCHv2] samba: Add packagegroup
> 
> Add packagegroup for samba, for there are too many rpms in samba and it's hard to manage.
> 
> Signed-off-by: Zheng Ruoqin <zhengrq.fnst at cn.fujitsu.com>
> ---
>  .../recipes-connectivity/samba/samba_4.6.7.bb         | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.6.7.bb 
> b/meta-networking/recipes-connectivity/samba/samba_4.6.7.bb
> index 2b227c9..0bacb02 100644
> --- a/meta-networking/recipes-connectivity/samba/samba_4.6.7.bb
> +++ b/meta-networking/recipes-connectivity/samba/samba_4.6.7.bb
> @@ -162,7 +162,7 @@ PACKAGES =+ "${PN}-python ${PN}-pidl \
>               ${PN}-dsdb-modules ${PN}-testsuite registry-tools \
>               winbind \
>               ${PN}-common ${PN}-base ${PN}-ctdb-tests \
> -             smbclient"
> +             smbclient ${PN}-client ${PN}-test"
>  
>  python samba_populate_packages() {
>      def module_hook(file, pkg, pattern, format, basename):
> @@ -254,3 +254,20 @@ FILES_smbclient = "${bindir}/cifsdd \
>  
>  RDEPENDS_${PN}-pidl_append = " perl"
>  FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse"
> +
> +SUMMARY_${PN}-client = "samba client"
> +RDEPENDS_${PN}-client = "\
> +    smbclient \
> +    winbind \
> +    registry-tools \
> +    ${PN}-pidl \
> +    " 
> +
> +ALLOW_EMPTY_${PN}-client = "1"
> +
> +RDEPENDS_${PN}-test = "\
> +    ${PN}-ctdb-tests \
> +    ${PN}-testsuite \
> +    "
> +
> +ALLOW_EMPTY_${PN}-test = "1"

--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel at lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel