[oe] [meta-oe][PATCH] iozone3: Upgrade to 482

[Yu, Mingli]

On 2018年07月09日 14:58, Peter Kjellerstedt wrote:
>> -----Original Message-----
>> From: openembedded-devel-bounces at lists.openembedded.org
>> [mailto:openembedded-devel-bounces at lists.openembedded.org] On Behalf Of
>> Yu, Mingli
>> Sent: den 9 juli 2018 08:37
>> To: Peter Kjellerstedt <peter.kjellerstedt at axis.com>; Khem Raj
>> <raj.khem at gmail.com>
>> Cc: openembeded-devel <openembedded-devel at lists.openembedded.org>
>> Subject: Re: [oe] [meta-oe][PATCH] iozone3: Upgrade to 482
>>
>> On 2018年07月09日 14:37, Peter Kjellerstedt wrote:
>>>> -----Original Message-----
>>>> From: openembedded-devel-bounces at lists.openembedded.org
>>>> [mailto:openembedded-devel-bounces at lists.openembedded.org] On Behalf
>> Of
>>>> Khem Raj
>>>> Sent: den 9 juli 2018 06:02
>>>> To: Yu, Mingli <mingli.yu at windriver.com>
>>>> Cc: openembeded-devel <openembedded-devel at lists.openembedded.org>
>>>> Subject: Re: [oe] [meta-oe][PATCH] iozone3: Upgrade to 482
>>>>
>>>> On Sun, Jul 8, 2018 at 7:29 PM Yu, Mingli <mingli.yu at windriver.com>
>>>> wrote:
>>>>> On 2018年07月06日 23:01, Khem Raj wrote:
>>>>>> On Fri, Jul 6, 2018 at 2:27 AM Yu, Mingli
>> <mingli.yu at windriver.com>
>>>>> wrote:
>>>>>>> On 2018年07月06日 00:00, Khem Raj wrote:
>>>>>>>> On Wed, Jul 4, 2018 at 11:54 PM <mingli.yu at windriver.com> wrote:
>>>>>>>>>
>>>>>>>>> From: Mingli Yu <mingli.yu at windriver.com>
>>>>>>>>>
>>>>>>>>> Update LIC_FILES_CHKSUM as the file iozone.c
>>>>>>>>> used for LIC_FILES_CHKSUM updated
>>>>>>>>>
>>>>>>>>
>>>>>>>> Please describe what has changed that is causing the checksums
>> to
>>>>>>>> change.
>>>>>>>
>>>>>>> The source file iozone.c changed has causing the checksum change.
>>>>>>> I have already mention it in the commit message.
>>>>>>
>>>>>> Commit message does not say what changed,  We already know
>>>>>> something has changed thats causing the checksum change but here
>> we
>>>>>> usually document what changed specifically, purpose is to let
>> users
>>>>>> know of any change in licensing requirements that they need to be
>>>>>> aware of
>>>>>
>>>>> Thanks Khem!
>>>>>
>>>>> I will try to list the changes in V2 but actually the file iozone.c
>>>>> used for checksum is source file. It has so much code changes
>> unlike
>>>>> some packages use COPYRIGHT file or README.md file for checksum.
>>>>
>>>> Ok that’s probably not ideal then. It would be better to just use
>> the
>>>> needed lines from checksum
>>>
>>> Please note that it is only line 37-48 and 260-266 of iozone.c that
>> are used
>>> to calculate the checksums. However, I guess that that due to the
>> fact there
>>> is source in between line 48 and 260, some lines have been
>> added/removed, so
>>> that the line numbers used in the checksum calculation are now off
>> (or they
>>> were off already before). Looking at the current source, my guess is
>> that
>>> lines 260-266 should be changed to 269-275.
>>
>>>
>>> Someone should really ask upstream to include a LICENSE file....
>>
>> Thanks Peter!
>>
>> It's better to include a LICENSE file.
>>
>> But now, how about just use 37-48 lines to calculate the checksum?
>>
>> Hi Khem,
>> What's your opinion?
>>
>> Thanks,
>
> The problem is that the license information is really at lines 269-275.

Yes, it indeed locates the copyright lines into source file right now. 
Or we just change to the right copyright line accordingly if no 
specified LICENSE file there.

Thanks,

> And at lines 37-48. Which is a mess...
>
>>>>> Thanks,
>>>>>
>>>>>>
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>>>
>>>>>>>>> Signed-off-by: Mingli Yu <mingli.yu at windriver.com>
>>>>>>>>> ---
>>>>>>>>>      .../iozone3/{iozone3_465.bb => iozone3_482.bb}
>> | 6 +++---
>>>>>>>>>      1 file changed, 3 insertions(+), 3 deletions(-)
>>>>>>>>>      rename meta-oe/recipes-benchmark/iozone3/{iozone3_465.bb =>
>> iozone3_482.bb} (95%)
>>>>>>>>>
>>>>>>>>> diff --git a/meta-oe/recipes-benchmark/iozone3/iozone3_465.bb
>> b/meta-oe/recipes-benchmark/iozone3/iozone3_482.bb
>>>>>>>>> similarity index 95%
>>>>>>>>> rename from meta-oe/recipes-benchmark/iozone3/iozone3_465.bb
>>>>>>>>> rename to meta-oe/recipes-benchmark/iozone3/iozone3_482.bb
>>>>>>>>> index 191b93425..09306e044 100644
>>>>>>>>> --- a/meta-oe/recipes-benchmark/iozone3/iozone3_465.bb
>>>>>>>>> +++ b/meta-oe/recipes-benchmark/iozone3/iozone3_482.bb
>>>>>>>>> @@ -4,14 +4,14 @@ AUTHOR = "Don Capps <don.capps2 at verizon.net>,
>> William D. Norcott <wnorcott at us.or
>>>>>>>>>    SECTION = "console/tests"
>>>>>>>>>    LICENSE = "iozone3"
>>>>>>>>>    LIC_FILES_CHKSUM =
>> "file://iozone.c;beginline=37;endline=48;md5=7331260091868dcad0f9edea73
>> 5b5f4b \
>>>>>>>>> -
>> file://iozone.c;beginline=260;endline=266;md5=77f9ee51e45b57a7e7519c4fa
>> 0b4f00b \
>>>>>>>>> +
>> file://iozone.c;beginline=260;endline=266;md5=0aa488fd139eac078be6eca86
>> e1435e8 \
>>>>>>>>>    "
>>>>>>>>>    SRC_URI = "http://www.iozone.org/src/current/${BPN}_${PV}.tar
>> \
>>>>>>>>>        file://parallelism.patch \
>>>>>>>>>        file://copyright.txt \
>>>>>>>>>    "
>>>>>>>>> -SRC_URI[md5sum] = "c924e5e46fb1cf8145f420e8e57eb954"
>>>>>>>>> -SRC_URI[sha256sum] =
>> "2e3d72916e7d7340a7c505fc0c3d28553fcc5ff2daf41d811368e55bd4e6a293"
>>>>>>>>> +SRC_URI[md5sum] = "31ca1d3d28bc375c20a2808217cf212c"
>>>>>>>>> +SRC_URI[sha256sum] =
>> "2733feb63c96f77177c68f3d938f2294d5394d8554b2767c45cbe138b2f3ae30"
>>>>>>>>>
>>>>>>>>>    UPSTREAM_CHECK_REGEX = "iozone3_(?P<pver>\d+).tar"
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> 2.17.1
>>>
>>> //Peter
>
> //Peter
>