[oe] [meta-oe][PATCH 1/1] kernel-selftest: Add a recipe on kernel selftest

[Burton, Ross]

On 13 July 2018 at 15:06, Hongzhi.Song <hongzhi.song at windriver.com> wrote:
>+LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7 \

Why are you shipping your own copy of the kernel's COPYING file even
though you copy another in that prefunc?

Isn't it possible to just depend on kernel-source and build directly
from the kernel source tree?

> +# for bpf and vm
> +DEPENDS = " \
> +    elfutils \
> +    libcap \
> +    libcap-ng \
> +    fuse \
> +    util-linux \
> +    rsync-native \
> +"

Really not convinced these dependencies are accurate.

> +TEST_LIST = "bpf \
> +             vm \
> +"

You're not listing memfd in here, but that is the only place which
uses fuse as far as I can tell.

My suggestion is to trim the DEPENDS back to the core minimum and use
PACKAGECONIG to select what directories get built. This means you can
have optional test suites where the dependencies are not in oe-core
(fuse for memfd, for example), and get the right RDEPENDS too.

> +        oe_runmake -C ${S}/tools/testing/selftests/${i} INSTALL_PATH=${D}/opt/kselftest/${i} install

FHS says /opt is for sysadmin-installed tools that are not package
managed.  You're building a package.  You're also building a package
which is essentially ptest.  I'd say inherit ptest, write a runner,
and put all the binaries in $PTESTDIR.

Ross