[oe] [meta-oe][PATCH] pam-plugin-ccreds: add recipe

[Richard Leitner]

On 06/01/2018 08:01 PM, Andre McCurdy wrote:
> On Fri, Jun 1, 2018 at 10:40 AM, Khem Raj <raj.khem at gmail.com> wrote:
>> On 6/1/18 4:41 AM, Richard Leitner wrote:
>>> Add version 11 of the pam-plugin-ccreds with the debian patches applied.
>>
>> I see QA errors like below
>>
>> ERROR: pam-plugin-ccreds-11-r0 do_package_qa: QA Issue: non
>> -dev/-dbg/nativesdk- package contains symlink .so: pam-plugin-ccreds
>> path
>> '/work/core2-64-bec-linux-musl/pam-plugin-ccreds/11-r0/packages-split/pam-plugin-ccreds/lib/security/pam_ccreds.so'
>> [dev-so]

Thanks for that information.
Are other targets than "linux-musl" affected?

> 
> According to OE's sanity checks, a .so plug-in should not be a symlink.
> 
> See the do_install_append() in the libcgroup recipe in oe-core for an
> example of how to fix the issue.

IMHO in this case the better solution is to add the missing targets to
the following patch... Or does anybody know how to pass a wildcard like
linux* to AM_CONDITIONAL? Google wasn't very helpful here :-(


>>> diff --git a/meta-oe/recipes-extended/pam/pam-plugin-ccreds/0003-Set-EXTENSION_SO-also-for-linux-gnueabi-targets.patch b/meta-oe/recipes-extended/pam/pam-plugin-ccreds/0003-Set-EXTENSION_SO-also-for-linux-gnueabi-targets.patch
>>> new file mode 100644
>>> index 000000000..4f203f1a3
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-extended/pam/pam-plugin-ccreds/0003-Set-EXTENSION_SO-also-for-linux-gnueabi-targets.patch
>>> @@ -0,0 +1,29 @@
>>> +From 12d9bb59284bd01a9fcc3b9280698ffc23ef2ddc Mon Sep 17 00:00:00 2001
>>> +From: Richard Leitner <richard.leitner at skidata.com>
>>> +Date: Fri, 1 Jun 2018 13:24:15 +0200
>>> +Subject: [PATCH 3/3] Set EXTENSION_SO also for linux-gnueabi targets
>>> +
>>> +As EXTENSION_SO gets already set for linux and linux-gnu targets we
>>> +should set it also for linux-gnueabi targets.
>>> +
>>> +Signed-off-by: Richard Leitner <richard.leitner at skidata.com>
>>> +---
>>> + configure.in | 2 +-
>>> + 1 file changed, 1 insertion(+), 1 deletion(-)
>>> +
>>> +diff --git a/configure.in b/configure.in
>>> +index 0dbdf79..a434208 100644
>>> +--- a/configure.in
>>> ++++ b/configure.in
>>> +@@ -43,7 +43,7 @@ AC_SUBST(pam_ccreds_so_LD)
>>> + AC_SUBST(pam_ccreds_so_LDFLAGS)
>>> +
>>> + AM_CONDITIONAL(USE_NATIVE_LINKER, test -n "$pam_ccreds_so_LD")
>>> +-AM_CONDITIONAL(EXTENSION_SO, test "$target_os" = "linux" -o "$target_os" = "linux-gnu")
>>> ++AM_CONDITIONAL(EXTENSION_SO, test "$target_os" = "linux" -o "$target_os" = "linux-gnu" -o "$target_os" = "linux-gnueabi")
>>> + AM_CONDITIONAL(EXTENSION_1, test "$TARGET_OS" = "HPUX")
>>> +
>>> + if test -z "$use_gcrypt"; then
>>> +--
>>> +2.11.0

regards;Richard.L