[oe] [meta-networking][PATCH] spice: Uprev to fix compile errors from gcc 8.1.0

[Martin Jansa]

Looks good, but the -- in the commit message strips your Signed-off-by and
the info about PACKAGECONFIG.

Patchwork might be doing something strange here, in the commit message here
and on
https://patchwork.openembedded.org/patch/151765/
I see just 2 dashes, but after downloading the mbox as
https://patchwork.openembedded.org/patch/151765/mbox
there are 3 dashes (twice) and git strips it.

Cheers,


On Sat, Jun 16, 2018 at 3:24 PM Jason Wessel <jason.wessel at windriver.com>
wrote:

> The upstream spice already fixed the following problems:
>
> ../../git/server/red-channel.c: In function 'red_channel_receive':
> ../../git/server/red-channel.c:307:44: error: cast between incompatible
> function types from 'void (*)(RedChannelClient *)' {aka 'void (*)(struct
> RedChannelClient *)'} to 'void (*)(void *, void *)'
> [-Werror=cast-function-type]
>      g_list_foreach(channel->priv->clients,
> (GFunc)red_channel_client_receive, NULL);
>                                             ^
> ../../git/server/red-channel.c: In function 'red_channel_destroy':
> ../../git/server/red-channel.c:406:44: error: cast between incompatible
> function types from 'void (*)(RedChannelClient *)' {aka 'void (*)(struct
> RedChannelClient *)'} to 'void (*)(void *, void *)'
> [-Werror=cast-function-type]
>      g_list_foreach(channel->priv->clients,
> (GFunc)red_channel_client_destroy, NULL);
>                                             ^
> ../../git/server/red-channel.c: In function 'red_channel_send':
> ../../git/server/red-channel.c:412:44: error: cast between incompatible
> function types from 'void (*)(RedChannelClient *)' {aka 'void (*)(struct
> RedChannelClient *)'} to 'void (*)(void *, void *)'
> [-Werror=cast-function-type]
>      g_list_foreach(channel->priv->clients,
> (GFunc)red_channel_client_send, NULL);
>                                             ^
> ../../git/server/red-channel.c: In function 'red_channel_push':
> ../../git/server/red-channel.c:421:44: error: cast between incompatible
> function types from 'void (*)(RedChannelClient *)' {aka 'void (*)(struct
> RedChannelClient *)'} to 'void (*)(void *, void *)'
> [-Werror=cast-function-type]
>      g_list_foreach(channel->priv->clients,
> (GFunc)red_channel_client_push, NULL);
>                                             ^
> ../../git/server/red-channel.c: In function 'red_channel_disconnect':
> ../../git/server/red-channel.c:481:44: error: cast between incompatible
> function types from 'void (*)(RedChannelClient *)' {aka 'void (*)(struct
> RedChannelClient *)'} to 'void (*)(void *, void *)'
> [-Werror=cast-function-type]
>      g_list_foreach(channel->priv->clients,
> (GFunc)red_channel_client_disconnect, NULL);
>                                             ^
> ../../git/server/char-device.c: In function 'red_char_device_reset':
> ../../git/server/char-device.c:838:49: error: cast between incompatible
> function types from 'void (*)(RedPipeItem *)' {aka 'void (*)(struct
> RedPipeItem *)'} to 'void (*)(void *, void *)' [-Werror=cast-function-type]
>          g_queue_foreach(dev_client->send_queue,
> (GFunc)red_pipe_item_unref, NULL);
>
> --
>
> The new commit also changed opus to compile in by default.  This is
> now added as a PKGCONFIG option.
>
> Signed-off-by: Jason Wessel <jason.wessel at windriver.com>
> ---
>  meta-networking/recipes-support/spice/spice_git.bb | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta-networking/recipes-support/spice/spice_git.bb
> b/meta-networking/recipes-support/spice/spice_git.bb
> index 35482ca86..e12e7d691 100644
> --- a/meta-networking/recipes-support/spice/spice_git.bb
> +++ b/meta-networking/recipes-support/spice/spice_git.bb
> @@ -15,8 +15,8 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
>
>  PV = "0.14.0+git${SRCPV}"
>
> -SRCREV_spice = "2a3d5624382ba49c4eb906e69697b92f79d06cf4"
> -SRCREV_spice-common = "4c2d0e977272c5540634d24f485dd64c424f6748"
> +SRCREV_spice = "f1050bfc76c9c4146257e087baf74e0b62d7d218"
> +SRCREV_spice-common = "95743f40a2da39e0a19859c305e69e2c99d39e42"
>
>  SRCREV_FORMAT = "spice_spice-common"
>
> @@ -47,6 +47,7 @@ PACKAGECONFIG[smartcard] =
> "--enable-smartcard,--disable-smartcard,libcacard,"
>  PACKAGECONFIG[sasl] = "--with-sasl,--without-sasl,cyrus-sasl,"
>  PACKAGECONFIG[client] = "--enable-client,--disable-client,,"
>  PACKAGECONFIG[gui] = "--enable-gui,--disable-gui,,"
> +PACKAGECONFIG[opus] = "--enable-opus,--disable-opus,libopus,"
>  PACKAGECONFIG[opengl] = "--enable-opengl,--disable-opengl,,"
>  PACKAGECONFIG[xinerama] =
> "--enable-xinerama,--disable-xinerama,libxinerama,"
>
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>