[oe] [meta-xfce][PATCH] xfce4-panel: fix QA issue 'installed-vs-shipped'

[Andreas Müller]

On Mon, Jun 18, 2018 at 4:45 PM, Mark Asselstine
<mark.asselstine at windriver.com> wrote:
> Since commit 5f31db601408 [xfce4-panel: upgrade 4.12.2 -> 4.13.3] we
> are getting a QA Warnings/Erros for 'installed-vs-shipped':
>
>     ERROR: xfce4-panel-4.13.3-r0 do_package: QA Issue: xfce4-panel:
>     Files/directories were installed but not shipped in any package:
>       /usr/lib64/xfce4/panel/plugins/liblauncher.la
>       /usr/lib64/xfce4/panel/plugins/libdirectorymenu.la
>       ...
>
> From various OE documents the .la files should not be packaged in
> either the main recipe package or the -dev package unless required. So
> inherit 'remove-libtool' to have all the .la files cleaned up as they
> don't appear to be necessary.
>
> Signed-off-by: Mark Asselstine <mark.asselstine at windriver.com>
> ---
>
> This error is currently only seen on master-next since the xfce4-panel
> upgrade commit is yet to make it into master. As such this fix is only
> applicable to master-next.
I think it was not the upgrade -> 4.13.3 commit but later commit / same series

various classes recipes: Remove FILES entries for dbg/dev packages
...
--- a/meta-xfce/classes/xfce.bbclass
+++ b/meta-xfce/classes/xfce.bbclass
@@ -12,11 +12,3 @@ DEPENDS += "intltool-native"

 FILES_${PN} += "${datadir}/icons/* ${datadir}/applications/*
${libdir}/xfce4/modules/*.so*"
 FILES_${PN}-doc += "${datadir}/xfce4/doc"
-
-FILES_${PN}-dev += "${libdir}/xfce4/*/*.la"
-FILES_${PN}-dev += "${libdir}/xfce4/*/*/*.la"
...

My builds have remove-libtool enabled so I did not see this QA warning/error.

Isn't remove-libtool enabled by default since pyro/2.3 - so that this
patch is obsolete (and all the other same kind coming later)?

Andreas