[oe] [meta-xfce][PATCH] thunar: fix QA issue 'installed-vs-shipped'

[Khem Raj]

On Mon, Jun 18, 2018 at 11:03 AM Mark Asselstine
<mark.asselstine at windriver.com> wrote:
>
> On Mon, Jun 18, 2018 at 1:51 PM, Khem Raj <raj.khem at gmail.com> wrote:
> > On Mon, Jun 18, 2018 at 9:51 AM Mark Asselstine
> > <mark.asselstine at windriver.com> wrote:
> >>
> >> Since commit eb0fe21c1535 [thunar: upgrade 1.6.15 -> 1.8.0] we see a
> >> QA Error/Warning regarding files 'installed-vs-shipped':
> >>
> >>     ERROR: QA Issue: thunar: Files/directories were installed but not
> >>     shipped in any package:
> >>       /usr/lib
> >>       /usr/lib/systemd
> >>       /usr/lib/systemd/user
> >>       /usr/lib/systemd/user/thunar.service
> >>
> >
> > perhaps this should be moved to /lib/systemd/system
>
> Possibly but really I had to go under the assumption that the folks
> that came before me and created the recipe and completed version bumps
> have tested it in its current location (which is a valid location for
> systemd service files by the way). So my intention was to address the
> QA issue and not change the overall behavior of the recipe.
>

Thats fine.  Let me wait on Andreas to validate this approach.

> MarkA
>
> >
> >> Correct the path to the systemd service file to match what we see in
> >> other recipes which include "user" service files.
> >>
> >> Signed-off-by: Mark Asselstine <mark.asselstine at windriver.com>
> >> ---
> >>
> >> This issue and patch is for master-next to match the
> >> merge status of commit eb0fe21c1535.
> >>
> >>  meta-xfce/recipes-xfce/thunar/thunar_1.8.0.bb | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta-xfce/recipes-xfce/thunar/thunar_1.8.0.bb b/meta-xfce/recipes-xfce/thunar/thunar_1.8.0.bb
> >> index f03fd63..c2f6f59 100644
> >> --- a/meta-xfce/recipes-xfce/thunar/thunar_1.8.0.bb
> >> +++ b/meta-xfce/recipes-xfce/thunar/thunar_1.8.0.bb
> >> @@ -21,7 +21,7 @@ FILES_${PN} += " \
> >>      ${libdir}/thunarx-3/* \
> >>      ${libdir}/xfce4/panel/plugins/* \
> >>      ${libdir}/Thunar/[Tt]hunar* \
> >> -    ${libdir}/systemd \
> >> +    ${systemd_user_unitdir} \
> >>      ${datadir}/dbus-1 \
> >>      ${datadir}/metainfo \
> >>      ${datadir}/polkit-1 \
> >> --
> >> 2.7.4
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel at lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > --
> > ________________________http://lists.openembedded.org/pipermail/openembedded-devel/2016-March/106323.html_______________________
> > Openembedded-devel mailing list
> > Openembedded-devel at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel