[oe] [meta-networking][PATCH] curlpp: Fix packaging and reference to license

[Khem Raj]

On Wed, Nov 7, 2018 at 7:32 AM Robert Tiemann <rtie at gmx.de> wrote:
>
> This patch fixes three issues:
>
> 1. The recipe used "libcurlpp" for its package base name. It defined
>   PACKAGES and corresponding package contents manually, but the
>   non-standard naming led to an error message when trying to depend on
>   it (nothing provides curlpp needed by curlpp-dev).
>
>   See also
>   https://lists.yoctoproject.org/pipermail/poky/2018-February/011236.html.
>
>   Fixed by removing PACKAGES and corresponding FILES_*, relying on
>   automatic packaging now.
>
> 2. Upstream ships a license file (MIT), which is referenced by the
>   recipe now (instead of the stock COPYING.MIT file).
>
> 3. There was a do_install_append() function which patched the
>   installed curlpp.pc file. Since it seemed to be of no use, it was
>   removed.
>
> Signed-off-by: Robert Tiemann <rtie at gmx.de>
> ---
>  .../recipes-support/curlpp/curlpp_0.8.1.bb     | 18 ++----------------
>  1 file changed, 2 insertions(+), 16 deletions(-)
>
> diff --git a/meta-networking/recipes-support/curlpp/curlpp_0.8.1.bb b/meta-networking/recipes-support/curlpp/curlpp_0.8.1.bb
> index 340f57dc7..f92cf65cf 100644
> --- a/meta-networking/recipes-support/curlpp/curlpp_0.8.1.bb
> +++ b/meta-networking/recipes-support/curlpp/curlpp_0.8.1.bb
> @@ -2,7 +2,7 @@ SUMMARY = "C++ library for client-side URL transfers"
>  HOMEPAGE = "http://www.curlpp.org/"
>  SECTION = "libdevel"
>  LICENSE = "MIT"
> -LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> +LIC_FILES_CHKSUM = "file://doc/LICENSE;md5=fd0c9adf285a69aa3b4faf34384e1029"
>
>  DEPENDS = "curl"
>  DEPENDS_class-native = "curl-native"
> @@ -10,24 +10,10 @@ DEPENDS_class-native = "curl-native"
>  SRC_URI = "git://github.com/jpbarrette/curlpp.git"
>
>  SRCREV = "592552a165cc569dac7674cb7fc9de3dc829906f"
> +PR = "r1"

this is not needed. Please drop it

>
>  S = "${WORKDIR}/git"
>
>  inherit cmake pkgconfig binconfig
>
> -do_install_append () {
> -    sed -i 's,${STAGING_DIR_TARGET},,g' ${D}${libdir}/pkgconfig/curlpp.pc
> -}
> -
> -PACKAGES =+ "libcurlpp libcurlpp-dev libcurlpp-staticdev"
> -
> -FILES_lib${BPN} = "${libdir}/lib*.so.*"
> -
> -FILES_lib${BPN}-dev = "${includedir} \
> -    ${libdir}/pkgconfig \
> -    ${bindir}/*-config \
> -"
> -
> -FILES_lib${BPN}-staticdev = "${libdir}/lib*.a"
> -
>  BBCLASSEXTEND = "native nativesdk"
> --
> 2.19.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel