[oe] [meta-networking][PATCH] geoip: add downloadfilename for geoip database files

[Martin Jansa]

Looks, good.

Adding variable for 20181120 might help with maintenance (if we need to
change just checksums in future). And with good variable name (or a
comment) it would also document in the recipe why we're using this in
downloadfilename.

On Tue, Nov 20, 2018 at 7:48 AM <changqing.li at windriver.com> wrote:

> From: Changqing Li <changqing.li at windriver.com>
>
> previous change of checksum don't trigger archive to re-downloaded,
> , which will cause checksum mismatch. add downloadfilename to
> trigger re-download.
>
> 1. for user with PREMIRROR, another benefit is it can still compile
> success event upstream checksum change frequently.
> 2. but for user don't use PREMIRROR, if upstream checksum changed,
> still might have checksum mismatch problem.
>
> Signed-off-by: Changqing Li <changqing.li at windriver.com>
> ---
>  .../recipes-support/geoip/geoip_1.6.12.bb          | 24
> +++++++++++-----------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/meta-networking/recipes-support/geoip/geoip_1.6.12.bb
> b/meta-networking/recipes-support/geoip/geoip_1.6.12.bb
> index 1e1a7ff..57f0b67 100644
> --- a/meta-networking/recipes-support/geoip/geoip_1.6.12.bb
> +++ b/meta-networking/recipes-support/geoip/geoip_1.6.12.bb
> @@ -9,10 +9,10 @@ HOMEPAGE = "http://dev.maxmind.com/geoip/"
>  SECTION = "libdevel"
>
>  SRC_URI = "git://github.com/maxmind/geoip-api-c.git \
> -
> http://geolite.maxmind.com/download/geoip/database/GeoLiteCountry/GeoIP.dat.gz;apply=no;name=GeoIP-dat
> \
> -
> http://geolite.maxmind.com/download/geoip/database/GeoIPv6.dat.gz;apply=no;name=GeoIPv6-dat
> \
> -
> http://geolite.maxmind.com/download/geoip/database/GeoLiteCity.dat.gz;apply=no;name=GeoLiteCity-dat
> \
> -
> http://geolite.maxmind.com/download/geoip/database/GeoLiteCityv6-beta/GeoLiteCityv6.dat.gz;apply=no;name=GeoLiteCityv6-dat
> \
> +
> http://geolite.maxmind.com/download/geoip/database/GeoLiteCountry/GeoIP.dat.gz;apply=no;name=GeoIP-dat;downloadfilename=GeoIP.dat.20181120.gz
> \
> +
> http://geolite.maxmind.com/download/geoip/database/GeoIPv6.dat.gz;apply=no;name=GeoIPv6-dat;downloadfilename=GeoIPv6.dat.20181120.gz
> \
> +
> http://geolite.maxmind.com/download/geoip/database/GeoLiteCity.dat.gz;apply=no;name=GeoLiteCity-dat;downloadfilename=GeoLiteCity.dat.20181120.gz
> \
> +
> http://geolite.maxmind.com/download/geoip/database/GeoLiteCityv6-beta/GeoLiteCityv6.dat.gz;apply=no;name=GeoLiteCityv6-dat;downloadfilename=GeoLiteCityv6.dat.20181120.gz
> \
>             file://run-ptest \
>  "
>  SRCREV = "4b526e7331ca1d692b74a0509ddcc725622ed31a"
> @@ -20,14 +20,14 @@ SRCREV = "4b526e7331ca1d692b74a0509ddcc725622ed31a"
>  SRC_URI[GeoIP-dat.md5sum] = "d538e57ad9268fdc7955c6cf9a37c4a9"
>  SRC_URI[GeoIP-dat.sha256sum] =
> "b9c05eb8bfcf90a6ddfdc6815caf40a8db2710f0ce3dd48fbd6c24d485ae0449"
>
> -SRC_URI[GeoIPv6-dat.md5sum] = "00dc3b3f53eb5f7bf6915f939998f12c"
> -SRC_URI[GeoIPv6-dat.sha256sum] =
> "e72221fc630094d7256521b307e9142fb77d2167a27de2c11da536a2ba1d1480"
> +SRC_URI[GeoIPv6-dat.md5sum] = "a908d7a51c3883eb8f693ca197c7a142"
> +SRC_URI[GeoIPv6-dat.sha256sum] =
> "1b06e34eed2c539606a9ab4d97b2140ac80bf9f528d16ad2e3831c75014c2710"
>
>  SRC_URI[GeoLiteCity-dat.md5sum] = "d700c137232f8e077ac8db8577f699d9"
>  SRC_URI[GeoLiteCity-dat.sha256sum] =
> "90db2e52195e3d1bcdb2c2789209006d09de5c742812dbd9a1b36c12675ec4cd"
>
> -SRC_URI[GeoLiteCityv6-dat.md5sum] = "7f6333d433d8127181ea3c5828287c98"
> -SRC_URI[GeoLiteCityv6-dat.sha256sum] =
> "c339e20cdf326c18aa3571bcd27845e6daf41ca5bfe9401bc472908aaeb42ac7"
> +SRC_URI[GeoLiteCityv6-dat.md5sum] = "8ac3506ccabaae7e9f7d6301c2654313"
> +SRC_URI[GeoLiteCityv6-dat.sha256sum] =
> "1c5fced1657d09448b3ecc14b65c9536228a627d93ed4159d3438b2c6faa8506"
>
>  LICENSE = "LGPL-2.1"
>
> @@ -44,10 +44,10 @@ EXTRA_OECONF = "--disable-static               \
>  do_install() {
>      make DESTDIR=${D} install
>      install -d ${D}/${datadir}/GeoIP
> -    install ${WORKDIR}/GeoIP.dat ${D}/${datadir}/GeoIP/
> -    install ${WORKDIR}/GeoIPv6.dat ${D}/${datadir}/GeoIP/
> -    install ${WORKDIR}/GeoLiteCity.dat ${D}/${datadir}/GeoIP/
> -    install ${WORKDIR}/GeoLiteCityv6.dat ${D}/${datadir}/GeoIP/
> +    install ${WORKDIR}/GeoIP.dat.20181120 ${D}/${datadir}/GeoIP/GeoIP.dat
> +    install ${WORKDIR}/GeoIPv6.dat.20181120
> ${D}/${datadir}/GeoIP/GeoIPv6.dat
> +    install ${WORKDIR}/GeoLiteCity.dat.20181120
> ${D}/${datadir}/GeoIP/GeoLiteCity.dat
> +    install ${WORKDIR}/GeoLiteCityv6.dat.20181120
> ${D}/${datadir}/GeoIP/GeoLiteCityv6.dat
>      ln -s GeoLiteCity.dat ${D}${datadir}/GeoIP/GeoIPCity.dat
>  }
>
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>