[oe] [PATCH] evince: Drop x11 requirement

[Fabien Lahoudere]

Hi

Le mardi 20 novembre 2018 à 10:01 -0700, akuster808 a écrit :
> 
> On 11/20/18 8:36 AM, Martin Jansa wrote:
> > This was already removed once in:
> > 
> > commit 33c822a7c11df08f35dda18a44aae730f93c6130
> > Author: Fabien Lahoudere <fabien.lahoudere at collabora.co.uk>
> > Date:   Wed Sep 6 18:53:07 2017 +0200
> > 
> >     evince: Remove X dependency
> > 
> >     gnome-desktop is the only X dependency for evince.
> >     In order to build evince for Wayland based system without X
> > support,
> >     gnome-desktop is added to DEPENDS only if x11 exists in
> > DISTRO_FEATURES.
> >     So x11 is dropped from REQUIRED_DISTRO_FEATURES.
> > 
> >     Signed-off-by: Fabien Lahoudere <
> > fabien.lahoudere at collabora.co.uk>
> >     Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> > 
> > and then returned here:
> > commit 62376d673aa86b5f8ffb26c8a74046ee87ef4f66
> > Author: Armin Kuster <akuster808 at gmail.com>
> > Date:   Wed Mar 7 08:08:57 2018 -0800
> > 
> >     evince: only include when x11 in DISTRO_FEATURES
> > 
> >     Signed-off-by: Armin Kuster <akuster808 at gmail.com>
> > 
> > What's going on? But if everybody agrees on removing it, then you
> > should
> > remove the distro_features_check inherit as well.
> 
> Please run the yocto-check-layer.  Maybe another solution needs to
> submitted to get this to pass.
> 

I tested evince with two machines using wayland only and it builds and
runs correctly. X11 is not required to build this recipe and I think
that sanity-meta-gnome.bbclass leads to a wrong error message and is
redundant with 'REQUIRED_DISTRO_FEATURE ="x11"'.
Do you agree to drop this sanity check from meta-gnome?

Thanks

Fabien

> - armin
> > On Tue, Nov 20, 2018 at 5:24 PM Fabien Lahoudere <
> > fabien.lahoudere at collabora.com> wrote:
> > 
> > > evince works fine in a wayland only distribution.
> > > x11 requirement is not needed.
> > > 
> > > Signed-off-by: Fabien Lahoudere <fabien.lahoudere at collabora.com>
> > > ---
> > >  meta-gnome/recipes-gnome/evince/evince_3.28.2.bb | 2 --
> > >  1 file changed, 2 deletions(-)
> > > 
> > > diff --git a/meta-gnome/recipes-gnome/evince/evince_3.28.2.bb
> > > b/meta-gnome/recipes-gnome/evince/evince_3.28.2.bb
> > > index 8bf8a04..01f581a 100644
> > > --- a/meta-gnome/recipes-gnome/evince/evince_3.28.2.bb
> > > +++ b/meta-gnome/recipes-gnome/evince/evince_3.28.2.bb
> > > @@ -6,8 +6,6 @@ DEPENDS = "gtk+3 libsecret
> > > ${@bb.utils.contains('DISTRO_FEATURES','x11','gnome-d
> > > 
> > >  inherit gnome pkgconfig gtk-icon-cache gsettings gobject-
> > > introspection
> > > distro_features_check systemd
> > > 
> > > -REQUIRED_DISTRO_FEATURES = "x11"
> > > -
> > >  SRC_URI =
> > > "${GNOME_MIRROR}/${GNOMEBN}/${@gnome_verdir("${PV}")}/${GNOMEBN}-
> > > ${PV}.tar.${GNOME_COMPRESS_TYPE};name=archive
> > > \
> > >             file://0001-help-remove-YELP-macro.patch \
> > >             file://0001-Add-format-attribute-to-
> > > _synctex_malloc.patch \
> > > --
> > > 1.8.3.1
> > > 
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel at lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > > 
> 
>