[oe] [meta-oe][PATCHv2] iwd: add version 0.12

[Burton, Ross]

On Thu, 22 Nov 2018 at 12:48, Martin Hundebøll <martin at geanix.com> wrote:
> +DEPENDS += "${@bb.utils.contains('PTEST_ENABLED', '1', 'readline', '', d)}"

Better to fix the makefile so it doesn't build the client test if the
client is disabled?

> +SRC_URI = " \
> +    git://git.kernel.org/pub/scm/network/wireless/iwd.git \
> +    file://0001-configure.ac-enable-serial-tests-in-automake-to-supp.patch \

Oh, I've a patch to automake to make this redundant.  I'll dig it out
and post to oe-core.

> +HAVE_SYSTEMD = "${@bb.utils.contains('PACKAGECONFIG', 'systemd', True, False, d)}"
> +
> +# iwd service
> +SYSTEMD_SERVICE_${PN} = "${@'iwd.service' if bb.utils.to_boolean(d.getVar('HAVE_SYSTEMD')) else ''}"
> +FILES_${PN} += " \
> +    ${datadir}/dbus-1/system.d/iwd-dbus.conf \
> +    ${datadir}/dbus-1/system-services/net.connman.iwd.service \
> +"

No need, if systemd is disabled then the class won't do anything.

> +# iwctl tool
> +PN_CLIENT = "${@bb.utils.contains('PACKAGECONFIG', 'client', '${PN}-client', '', d)}"
> +RRECOMMENDS_${PN} += "${PN_CLIENT}"
> +PACKAGE_BEFORE_PN += "${PN_CLIENT}"
> +FILES_${PN}-client += "${bindir}/iwctl"

I'm generally against massively splitting up recipes in the name of
modularity as it just complicates recipes.  Unless there's a good
reason I'd say just put the daemon, the client, and the extra parts
(such as EAD) in the same package.  It's not like anyone would want to
install the client but not the daemon, or installing the client
alongside the daemon would be a huge waste of space.

Ross