[oe] [meta-networking][PATCH] geoip: add downloadfilename for geoip database files

Khem Raj raj.khem at gmail.com
Thu Nov 29 01:55:08 UTC 2018


We have two options

Download and rename may be add a date component and save it on
sources.oe.org

Second option is to download the databases during build as temporary
artifacts but this might cause reproducibility problems

Either way it is going to have some issues
May be option 1 even though tedious can be better of two

On Wed, Nov 28, 2018 at 5:31 PM Changqing Li <changqing.li at windriver.com>
wrote:

> Khem and Marthin,
>
> The failure still caused by frequently changed checksum of the database. I
> send the patch on 11.20.
>
> but the checksum changed on 1121, and it also changed on 1128, seems like
> weekly change.
>
> but it should not failed if there is a premirror saved the
>
> Here is a result I get:
>
> $ md5sum 1128/*v6*
> d98a04eded0b08b945b5629106d58760  1128/GeoIPv6 (1).dat.gz
> 4d48c102ec68298b3fc7f57763455cb5  1128/GeoLiteCityv6.dat.gz
> $ md5sum 1121/*v6*
> b0f82334f94ca89872e7722db3511bb9  1121/GeoIPv6.dat.gz
> 50ad18a8a3ea4bba7c929bea6e22db75  1121/GeoLiteCityv6.dat.gz
> $ md5sum 1120/*v6*
> a908d7a51c3883eb8f693ca197c7a142  1120/GeoIPv6.dat.gz
> 8ac3506ccabaae7e9f7d6301c2654313  1120/GeoLiteCityv6.dat.gz
>
>
> On 11/28/18 3:14 AM, Martin Jansa wrote:
>
> I'm seeing different checksum than both your builder and the recipe.
>
> $ wget http://geolite.maxmind.com/download/geoip/database/GeoIPv6.dat.gz
> --2018-11-27 20:06:32--
> http://geolite.maxmind.com/download/geoip/database/GeoIPv6.dat.gz
> Resolving geolite.maxmind.com... 104.16.37.47, 104.16.38.47,
> 2606:4700::6810:252f, ...
> Connecting to geolite.maxmind.com|104.16.37.47|:80... connected.
> HTTP request sent, awaiting response... 200 OK
> Length: 1209046 (1.2M) [application/octet-stream]
> Saving to: ‘GeoIPv6.dat.gz’
>
> 2018-11-27 20:06:32 (10.3 MB/s) - ‘GeoIPv6.dat.gz’ saved [1209046/1209046]
>
> $ md5sum GeoIPv6.dat.gz
> d98a04eded0b08b945b5629106d58760  GeoIPv6.dat.gz
>
> Is this the legacy archive? Because
> https://dev.maxmind.com/geoip/legacy/geolite/ now shows following:
>
> Yes,  I have  pointed out this problem  the first time I changed the
> checksum. maybe we should upgrade
>
> to geoip2,  and  drop current geoip1.6.  but I think even with geoip2,
> since it's database still not version,
>
> maybe also will met similar problem.
>
>
> //changqing
>
>
> Updated versions of the GeoLite Legacy databases are now only available to
> redistribution license customers, although anyone can continue to download
> the March 2018 GeoLite Legacy builds. Starting January 2, 2019, the last
> build will be removed from our website. GeoLite Legacy database users will
> need to switch to the GeoLite2 or commercial GeoIP databases and update
> their integrations by January 2, 2019.
>
> For more information, please visit our Support Center.
>
> Note: After careful consideration, taking into account customer feedback,
> we have decided against removing latitude and longitude coordinates from
> the GeoLite2 databases. We are in the process of reviewing coordinates used
> in all of our GeoLite2 and GeoIP databases to ensure there is no risk of
> misuse.
>
> * GeoLite2 databases are free IP geolocation databases comparable to, but
> less accurate than, MaxMind’s GeoIP2 databases. Please remember to use the
> accuracy radius if displaying coordinates on a map.
>
> New Database Format Available: This page is for our GeoLite Legacy
> databases. For our latest database format, please visit our GeoLite2
> Databases page. We offer redistribution licenses for our newer GeoLite2
> databases that will allow you to package the databases with your commercial
> products. For more information, please visit the GeoLite2 Commercial
> Redistribution page.
>
>
> On Tue, Nov 27, 2018 at 8:04 PM Khem Raj <raj.khem at gmail.com> wrote:
>
>> I am seeing errors on some builders
>>
>> http://errors.yoctoproject.org/Errors/Details/202341/
>> On Mon, Nov 19, 2018 at 11:29 PM Martin Jansa <martin.jansa at gmail.com>
>> wrote:
>> >
>> > Looks, good.
>> >
>> > Adding variable for 20181120 might help with maintenance (if we need to
>> > change just checksums in future). And with good variable name (or a
>> > comment) it would also document in the recipe why we're using this in
>> > downloadfilename.
>> >
>> > On Tue, Nov 20, 2018 at 7:48 AM <changqing.li at windriver.com> wrote:
>> >
>> > > From: Changqing Li <changqing.li at windriver.com>
>> > >
>> > > previous change of checksum don't trigger archive to re-downloaded,
>> > > , which will cause checksum mismatch. add downloadfilename to
>> > > trigger re-download.
>> > >
>> > > 1. for user with PREMIRROR, another benefit is it can still compile
>> > > success event upstream checksum change frequently.
>> > > 2. but for user don't use PREMIRROR, if upstream checksum changed,
>> > > still might have checksum mismatch problem.
>> > >
>> > > Signed-off-by: Changqing Li <changqing.li at windriver.com>
>> > > ---
>> > >  .../recipes-support/geoip/geoip_1.6.12.bb          | 24
>> > > +++++++++++-----------
>> > >  1 file changed, 12 insertions(+), 12 deletions(-)
>> > >
>> > > diff --git a/meta-networking/recipes-support/geoip/geoip_1.6.12.bb
>> > > b/meta-networking/recipes-support/geoip/geoip_1.6.12.bb
>> > > index 1e1a7ff..57f0b67 100644
>> > > --- a/meta-networking/recipes-support/geoip/geoip_1.6.12.bb
>> > > +++ b/meta-networking/recipes-support/geoip/geoip_1.6.12.bb
>> > > @@ -9,10 +9,10 @@ HOMEPAGE = "http://dev.maxmind.com/geoip/"
>> > >  SECTION = "libdevel"
>> > >
>> > >  SRC_URI = "git://github.com/maxmind/geoip-api-c.git \
>> > > -
>> > >
>> http://geolite.maxmind.com/download/geoip/database/GeoLiteCountry/GeoIP.dat.gz;apply=no;name=GeoIP-dat
>> > > \
>> > > -
>> > >
>> http://geolite.maxmind.com/download/geoip/database/GeoIPv6.dat.gz;apply=no;name=GeoIPv6-dat
>> > > \
>> > > -
>> > >
>> http://geolite.maxmind.com/download/geoip/database/GeoLiteCity.dat.gz;apply=no;name=GeoLiteCity-dat
>> > > \
>> > > -
>> > >
>> http://geolite.maxmind.com/download/geoip/database/GeoLiteCityv6-beta/GeoLiteCityv6.dat.gz;apply=no;name=GeoLiteCityv6-dat
>> > > \
>> > > +
>> > >
>> http://geolite.maxmind.com/download/geoip/database/GeoLiteCountry/GeoIP.dat.gz;apply=no;name=GeoIP-dat;downloadfilename=GeoIP.dat.20181120.gz
>> > > \
>> > > +
>> > >
>> http://geolite.maxmind.com/download/geoip/database/GeoIPv6.dat.gz;apply=no;name=GeoIPv6-dat;downloadfilename=GeoIPv6.dat.20181120.gz
>> > > \
>> > > +
>> > >
>> http://geolite.maxmind.com/download/geoip/database/GeoLiteCity.dat.gz;apply=no;name=GeoLiteCity-dat;downloadfilename=GeoLiteCity.dat.20181120.gz
>> > > \
>> > > +
>> > >
>> http://geolite.maxmind.com/download/geoip/database/GeoLiteCityv6-beta/GeoLiteCityv6.dat.gz;apply=no;name=GeoLiteCityv6-dat;downloadfilename=GeoLiteCityv6.dat.20181120.gz
>> > > \
>> > >             file://run-ptest \
>> > >  "
>> > >  SRCREV = "4b526e7331ca1d692b74a0509ddcc725622ed31a"
>> > > @@ -20,14 +20,14 @@ SRCREV =
>> "4b526e7331ca1d692b74a0509ddcc725622ed31a"
>> > >  SRC_URI[GeoIP-dat.md5sum] = "d538e57ad9268fdc7955c6cf9a37c4a9"
>> > >  SRC_URI[GeoIP-dat.sha256sum] =
>> > > "b9c05eb8bfcf90a6ddfdc6815caf40a8db2710f0ce3dd48fbd6c24d485ae0449"
>> > >
>> > > -SRC_URI[GeoIPv6-dat.md5sum] = "00dc3b3f53eb5f7bf6915f939998f12c"
>> > > -SRC_URI[GeoIPv6-dat.sha256sum] =
>> > > "e72221fc630094d7256521b307e9142fb77d2167a27de2c11da536a2ba1d1480"
>> > > +SRC_URI[GeoIPv6-dat.md5sum] = "a908d7a51c3883eb8f693ca197c7a142"
>> > > +SRC_URI[GeoIPv6-dat.sha256sum] =
>> > > "1b06e34eed2c539606a9ab4d97b2140ac80bf9f528d16ad2e3831c75014c2710"
>> > >
>> > >  SRC_URI[GeoLiteCity-dat.md5sum] = "d700c137232f8e077ac8db8577f699d9"
>> > >  SRC_URI[GeoLiteCity-dat.sha256sum] =
>> > > "90db2e52195e3d1bcdb2c2789209006d09de5c742812dbd9a1b36c12675ec4cd"
>> > >
>> > > -SRC_URI[GeoLiteCityv6-dat.md5sum] =
>> "7f6333d433d8127181ea3c5828287c98"
>> > > -SRC_URI[GeoLiteCityv6-dat.sha256sum] =
>> > > "c339e20cdf326c18aa3571bcd27845e6daf41ca5bfe9401bc472908aaeb42ac7"
>> > > +SRC_URI[GeoLiteCityv6-dat.md5sum] =
>> "8ac3506ccabaae7e9f7d6301c2654313"
>> > > +SRC_URI[GeoLiteCityv6-dat.sha256sum] =
>> > > "1c5fced1657d09448b3ecc14b65c9536228a627d93ed4159d3438b2c6faa8506"
>> > >
>> > >  LICENSE = "LGPL-2.1"
>> > >
>> > > @@ -44,10 +44,10 @@ EXTRA_OECONF = "--disable-static               \
>> > >  do_install() {
>> > >      make DESTDIR=${D} install
>> > >      install -d ${D}/${datadir}/GeoIP
>> > > -    install ${WORKDIR}/GeoIP.dat ${D}/${datadir}/GeoIP/
>> > > -    install ${WORKDIR}/GeoIPv6.dat ${D}/${datadir}/GeoIP/
>> > > -    install ${WORKDIR}/GeoLiteCity.dat ${D}/${datadir}/GeoIP/
>> > > -    install ${WORKDIR}/GeoLiteCityv6.dat ${D}/${datadir}/GeoIP/
>> > > +    install ${WORKDIR}/GeoIP.dat.20181120
>> ${D}/${datadir}/GeoIP/GeoIP.dat
>> > > +    install ${WORKDIR}/GeoIPv6.dat.20181120
>> > > ${D}/${datadir}/GeoIP/GeoIPv6.dat
>> > > +    install ${WORKDIR}/GeoLiteCity.dat.20181120
>> > > ${D}/${datadir}/GeoIP/GeoLiteCity.dat
>> > > +    install ${WORKDIR}/GeoLiteCityv6.dat.20181120
>> > > ${D}/${datadir}/GeoIP/GeoLiteCityv6.dat
>> > >      ln -s GeoLiteCity.dat ${D}${datadir}/GeoIP/GeoIPCity.dat
>> > >  }
>> > >
>> > > --
>> > > 2.7.4
>> > >
>> > > --
>> > > _______________________________________________
>> > > Openembedded-devel mailing list
>> > > Openembedded-devel at lists.openembedded.org
>> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>> > >
>> > --
>> > _______________________________________________
>> > Openembedded-devel mailing list
>> > Openembedded-devel at lists.openembedded.org
>> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
> --
> BRs
>
> Sandy(Li Changqing)
>
>


More information about the Openembedded-devel mailing list