[oe] [meta-oe][PATCH] cli11: Add recipe

[Khem Raj]

On Tue, Oct 2, 2018 at 11:00 PM William A. Kennington III via
Openembedded-devel <openembedded-devel at lists.openembedded.org> wrote:
>
> cli11 is a c++ command line parser library that provides a simple
> user interface with modern c++ semantics.
>
> Signed-off-by: William A. Kennington III <wak at google.com>
> ---
>  meta-oe/recipes-support/cli11/cli11_1.6.1.bb | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 meta-oe/recipes-support/cli11/cli11_1.6.1.bb
>
> diff --git a/meta-oe/recipes-support/cli11/cli11_1.6.1.bb b/meta-oe/recipes-support/cli11/cli11_1.6.1.bb
> new file mode 100644
> index 000000000..2d231b98c
> --- /dev/null
> +++ b/meta-oe/recipes-support/cli11/cli11_1.6.1.bb
> @@ -0,0 +1,19 @@
> +SUMMARY = "C++11 command line parser"
> +DESCRIPTION = "A command line parser for C++11 and beyond that provides a rich feature set with a simple and intuitive interface."
> +HOMEPAGE = "https://github.com/CLIUtils/CLI11"
> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=c271fee3ae28e11b24b97284d9f82887"
> +SRCREV = "v${PV}"

it better for reproducibility that we include the SHA corresponding to
this tag instead

> +PV = "1.6.1"
> +PR = "r1"
> +

drop setting PR

> +SRC_URI += "git://github.com/CLIUtils/CLI11"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit cmake
> +
> +EXTRA_OECMAKE_append += " \

_append/_prepend with += is not a defined operation even
though it might result in something. We might be ok with just

EXTRA_OECMAKE +=

here

> +        -DCLI11_TESTING=OFF \
> +        -DCLI11_EXAMPLES=OFF \
> +        "

why are tests and examples disabled ?
I would prefer them to be part of build and packaged into
different PACKAGES so we can install them if needed e.g.
may be with ptest enabled we can install the tests package

> --
> 2.19.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel