[oe] [meta-oe][PATCH] ceres-solver: Removed empty package

Vyacheslav Yurkov uvv.mail at gmail.com
Fri Oct 5 09:50:40 UTC 2018


I'm bit behind with oe-core (not on master) and was not aware of that.
Anyway I was about to send v2, because I realized that static library and
headers should come together, and it doesn't make sense to specify two
packages.

Vyacheslav

On Fri, Oct 5, 2018 at 11:43 AM Martin Jansa <martin.jansa at gmail.com> wrote:

> On Fri, Oct 05, 2018 at 11:17:22AM +0200, Vyacheslav Yurkov wrote:
> > By default ceres-solver provides a static library and headers.
> > This change removes an empty package and sets an implicit dependency
> > on dev and dbg packages.
> >
> > It also addresses missing cmake configuration files in dev package.
> >
> > Signed-off-by: Vyacheslav Yurkov <uvv.mail at gmail.com>
> > ---
> >  meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
> b/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
> > index ad7c8f2a3..13ca8efab 100644
> > --- a/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
> > +++ b/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
> > @@ -13,5 +13,8 @@ S = "${WORKDIR}/git"
> >
> >  inherit cmake
> >
> > +FILES_${PN}-dev += "${libdir}/cmake/"
>
> Why is this needed? cmake files are packaged automatically since oe-core
> commit:
>
> commit 543e39ad5e2baa0f1ece013a89483783e6b15dd9
> Author: Andre McCurdy <armccurdy at gmail.com>
> Date:   Tue Jun 26 12:48:11 2018 -0700
>
>     bitbake.conf: handle cmake -dev files packaging with default rules
>
> > +
> >  # Only a static library and headers are created
> > -ALLOW_EMPTY_${PN} = "1"
> > +RDEPENDS_${PN}-dev = ""
> > +RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
> > --
> > 2.19.0
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
>



More information about the Openembedded-devel mailing list