[oe] [meta-networking][PATCH] libldb: add pam to REQUIRED_DISTRO_FEATURES

[Martin Hundebøll]

Hi Martin,

On 29/09/2018 09.45, Martin Jansa wrote:
> It depends on pam DISTRO_FEATURES, because it depends on libpam since:
> commit a95726df4bb1c898da7e4d4dbf9e2846914061e4
> Author: Andreas Müller <schnitzeltony at googlemail.com>
> Date:   Sat Sep 17 12:04:42 2016 +0200
> 
>      samba: replace pam packageconfig by hard dependency
> 
>      samba links against libpam even if pam is not in packageconfig and
> libpam was
>      built before. This patch avoid this floating dependency - other
> solution could
>      not be found. For those who want packageconfig back, see discussion iat
> [1] for
>      further inspiration.

Hasn't this fix (from 2016) been obsoleted by recipe-specific-sysroots?

// Martin

>      [1]
> http://lists.openembedded.org/pipermail/openembedded-devel/2016-September/109143.html
> 
>      Signed-off-by: Andreas Müller <schnitzeltony at googlemail.com>
>      Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
>      Signed-off-by: Joe MacDonald <joe_macdonald at mentor.com>
> 
> 
> On Fri, Sep 28, 2018 at 11:04 PM S. Lockwood-Childs <sjl at vctlabs.com> wrote:
> 
>> On Fri, Sep 28, 2018 at 01:23:25PM -0700, Khem Raj wrote:
>>> On Fri, Sep 28, 2018 at 1:19 PM S. Lockwood-Childs <sjl at vctlabs.com>
>> wrote:
>>>>
>>>> Could you explain commit 0db9697dc6b8c a little bit, where libpam
>> became a
>>>> distro requirement for samba itself? I'm not sure why pam is a hard
>>>> requirement, rather than being PACKAGECONFIG option. I haven't tried
>> the server
>>>> ipk built with --without-pam but the client-side pieces are certainly
>> useful.
>>>> I've got a bbappend to override the pam forcing, and was just
>> wondering if
>>>> this change might be upstreamable.
>>>
>>> its lack of fine grained packaging that this was needed. If you can
>>> sort this out then I am all ears
>>
>> What are the packaging problems to be solved when pam support is disabled?
>>
>> Like I said we're only running the client-side stuff so far, so I'm
>> guessing
>> the problems came up in server-side packages. There were no build errors
>> from
>> --without-pam at least.
>>
>>>
>>>>
>>>> On Thu, Sep 27, 2018 at 02:02:51PM +0000, Martin Jansa wrote:
>>>>> * dependency on samba was added recently in:
>>>>>    libldb: Add samba to rdeps for pyldb
>>>>>    so now we need to match samba restriction to prevent:
>>>>>
>>>>> ERROR: Nothing RPROVIDES 'samba' (but
>> meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb RDEPENDS
>> on or otherwise requires it)
>>>>> samba was skipped: missing required distro feature 'pam' (not in
>> DISTRO_FEATURES)
>>>>> NOTE: Runtime target 'samba' is unbuildable, removing...
>>>>> Missing or unbuildable dependency chain was: ['samba']
>>>>> ERROR: Required build target 'meta-world-pkgdata' has no buildable
>> providers.
>>>>> Missing or unbuildable dependency chain was: ['meta-world-pkgdata',
>> 'libldb', 'samba']
>>>>>
>>>>> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
>>>>> ---
>>>>>   meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
>>>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
>> b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
>>>>> index 99e62f66bb..3c7e5455e9 100644
>>>>> --- a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
>>>>> +++ b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
>>>>> @@ -35,7 +35,8 @@ LIC_FILES_CHKSUM =
>> "file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada
>>>>>   SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
>>>>>   SRC_URI[sha256sum] =
>> "2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"
>>>>>
>>>>> -inherit waf-samba
>>>>> +inherit waf-samba distro_features_check
>>>>> +REQUIRED_DISTRO_FEATURES = "pam"
>>>>>
>>>>>   S = "${WORKDIR}/ldb-${PV}"
>>>>>
>>>>> --
>>>>> 2.17.1
>>>>>
>>>>> --
>>>>> _______________________________________________
>>>>> Openembedded-devel mailing list
>>>>> Openembedded-devel at lists.openembedded.org
>>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>>> --
>>>> _______________________________________________
>>>> Openembedded-devel mailing list
>>>> Openembedded-devel at lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>

-- 
Kind regards,
Martin Hundebøll
Embedded Linux Consultant

+45 61 65 54 61
martin at geanix.com

Geanix IVS
https://geanix.com
DK39600706