[oe] [meta-oe][PATCH] glog: upgrade 0.3.4 -> 0.3.5

[Vyacheslav Yurkov]

Hi Martin,
Thanks for the comment.

Thanks for comments. I will add this patch and I also what to append
RDEPENDS_${PN} += "libunwind".
I plan to send the updates this week.

Vyacheslav

On Mon, Oct 15, 2018 at 1:11 PM Martin Jansa <martin.jansa at gmail.com> wrote:

> On Tue, Oct 09, 2018 at 11:52:36AM +0200, Vyacheslav Yurkov wrote:
> > Well, two obvious reasons:
> > - glog fixes between 0.3.4 and 0.3.5
> > - cmake support, which simplifies dependency handling when SDK generation
> > is involved (for example for libraries like ceres-solver)
> >
> > I need to update my patch for finding libunwind, so I will send another
> > version soon. The question I have now is that glog builds static library
> by
> > default. What is the policy in that regard? Should a shared library be
> > preferred by default?
>
> I know I'm a bit late, but I have some questions about shared library.
>
> The preferred default should IMHO be the same as with 0.3.4 version
> which was shared library, but that's easy to add with small bbappend
> having:
> EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON"
>
> but unfortunately the SONAME in the library changed from:
> objdump -x usr/lib/libglog.so.0.0.0 | grep SONAME
>   SONAME               libglog.so.0
> in 0.3.4 to:
> objdump -x usr/lib/libglog.so.0.3.5  | grep SONAME
>   SONAME               libglog.so.0.3.5
>
> Which breaks all our prebuilt binaries which now correctly complain that
> there isn't libglog.so.0 provider in dependencies:
> QA Issue: /usr/lib/libfoo.so.1.2.3 contained in package libfoo requires
> libglog.so.0, but no providers found in RDEPENDS_libfoo
>
> Which is quite unfortunate for minor upgrade. Did they really change the
> ABI (and expect to change it in all future minor upgrades) or is this
> change just unexpected side-effect of using cmake instead of autotools?
>
> It looks the later, because if I build 0.3.5 version with autotools I
> get:
> objdump -x usr/lib/libglog.so.0.0.0 | grep SONAME
>   SONAME               libglog.so.0
>
> and there is patch for SOVERSION here as well:
> https://github.com/google/or-tools/blob/master/patches/glog.patch
>
> applied in master:
> https://github.com/google/glog/blob/master/CMakeLists.txt#L493
>
> https://github.com/google/glog/commit/6b6e38a7d53fe01f42ce34384cf4ba4c50e8cb65#diff-af3b638bc2a3e6c650974192a53c7291
>
> patch coming with this change backported to make it possible again to
> use the shared library.