[oe] [RFC meta-gnome][PATCH 07/16] geocode-glib: add recipe for geocode-glib library

[Khem Raj]

On Mon, Oct 29, 2018 at 9:42 AM brendank310 <brendank310 at gmail.com> wrote:

> From: Brendan Kerrigan <kerriganb at ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb at ainfosec.com>
> ---
>  .../recipes-gnome/gnome3/geocode-glib_git.bb  | 21 +++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb
> b/meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb
> new file mode 100644
> index 000000000..73332e374
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb
> @@ -0,0 +1,21 @@
> +DESCRIPTION = "Geocode Library for glib"
> +LICENSE = "GPLv2"


The checksum seems to be operating on a COPYING.LIB can you confirm its not
LGPL but rather GPL

>
> +DEPENDS = " \
> +           glib-2.0 \
> +           json-glib \
> +           libsoup-2.4 \
> +          "
> +
> +LIC_FILES_CHKSUM =
> "file://COPYING.LIB;md5=55ca817ccb7d5b5b66355690e9abc605"
> +
> +SRC_URI = "git://
> gitlab.gnome.org/GNOME/geocode-glib.git;protocol=http;branch=master;tag=3.26.0
> \
> +           "
> +


hmm tags are floating kind of commits so they would result in checking
remote repo on every fetch task it would be better to use a hard coded SHA

>
> +EXTRA_OEMESON += " -Denable-installed-tests=false -Denable-gtk-doc=false "
> +
> +FILES_${PN} += "${datadir}"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit pkgconfig meson gobject-introspection
> +
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>