[oe] [meta-networking][PATCH 2/2] civetweb: disable tests

[Pascal Bach]

On 30.10.2018 22:04, Khem Raj wrote:
> On Tue, Oct 30, 2018 at 7:35 AM Pascal Bach <pascal.bach at siemens.com> wrote:
>> Tests try to download third party code and bypass the bitbake fetcher to
>> do that. This will not work in environments with no internet access.
>>
>> Signed-off-by: Pascal Bach <pascal.bach at siemens.com>
>> ---
>>  meta-networking/recipes-connectivity/civetweb/civetweb_git.bb | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/meta-networking/recipes-connectivity/civetweb/civetweb_git.bb b/meta-networking/recipes-connectivity/civetweb/civetweb_git.bb
>> index 004cf960a..d681f7f30 100644
>> --- a/meta-networking/recipes-connectivity/civetweb/civetweb_git.bb
>> +++ b/meta-networking/recipes-connectivity/civetweb/civetweb_git.bb
>> @@ -23,6 +23,7 @@ EXTRA_OECMAKE = " \
>>      -DCIVETWEB_ENABLE_DUKTAPE=OFF \
>>      -DCIVETWEB_ENABLE_LUA=OFF \
>>      -DCIVETWEB_ENABLE_ASAN=OFF \
>> +    -DCIVETWEB_BUILD_TESTING=OFF \
>>  "
> Probably, it will be good to turn this into a packageconfig, I am fine
> to disable it by default
> but it might be useful to have it enabled with say images with ptest feature on.
I agree it might be useful, but it needs some change as I don't think we want to have a recipe that fetches code from somewhere without bitbake knowing about it.

Once the main CMake patches land I will try to look into how the whole ExternalProject [1] stuff works in CMake and how it could be better integrated into OE.
So for now I suggest to just deactivate it and then later re add it once I figured out a way to properly handle ExternalProject.

[1] https://cmake.org/cmake/help/latest/module/ExternalProject.html
>>  # Building with ninja fails on missing third_party/lib/libcheck.a (which
>> --
>> 2.11.0
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel