[oe] [PATCH 2/2] php: fix linker errors by setting `ac_cv_func_dlopen=no`

[Jeroen Hofstee]

Hi,


On 09/28/2018 06:02 PM, Khem Raj wrote:
> On Thu, Sep 27, 2018 at 1:35 PM Max Kellermann
> <max+openembedded at blarg.de> wrote:
>> On 2018/09/27 21:27, Jeroen Hofstee <jhofstee at victronenergy.com> wrote:
>>> Removing CACHED_CONFIGUREVARS completely also seems to work
>>> for 7.2.9, but perhaps 5.6 needs this?
>> I thought about this as well.  The reason for hard-coding those
>> variables is a mystery to me, because I thought doing such detections,
>> even when cross-compiling, is a first-class feature of autotools which
>> always works reliably.
> see http://git.openembedded.org/meta-openembedded/commit/?id=0d052a48c9fd6d2207f150729a20804e416c91b1

For what it is worth, php_5.6.36 builds fine without the 
CACHED_CONFIGUREVARS
and opcache enable. I am not sure I get this part "AC_CHECK_FUNC isn't 
suitable
for a cross-compile environment". Yes, it will check the cross compiler, 
but I would
expect the cross setup to be the same as on the target, or that should 
be fixed I
guess.

Anyway, no objection for the patch, since it does already fix something 
(building
without mysql support e.g.), but I am tempted to think the 
CACHED_CONFIGUREVARS
can be removed completely.

php 5.6.36 does seem to be broken in default setup though, with openssl 
enabled,
at least I had to disable it to test this, see below

Regards,
Jeroen


| 
/home/jeroen/software/venus-upstream/build/tmp-glibc/work/cortexa8hf-neon-ve-linux-gnueabi/php/5.6.36-r0/php-5.6.36/ext/openssl/openssl.c: 
In function 'zif_openssl_sign':
| 
/home/jeroen/software/venus-upstream/build/tmp-glibc/work/cortexa8hf-neon-ve-linux-gnueabi/php/5.6.36-r0/php-5.6.36/ext/openssl/openssl.c:4801:13: 
error: storage size of 'md_ctx' isn't known
|   EVP_MD_CTX md_ctx;
|              ^~~~~~
| 
/home/jeroen/software/venus-upstream/build/tmp-glibc/work/cortexa8hf-neon-ve-linux-gnueabi/php/5.6.36-r0/php-5.6.36/ext/openssl/openssl.c:4845:2: 
warning: implicit declaration of function 'EVP_MD_CTX_cleanup'; did you 
mean 'EVP_MD_CTX_create'? [-Wimplicit-function-declaration]
|   EVP_MD_CTX_cleanup(&md_ctx);
|   ^~~~~~~~~~~~~~~~~~
|   EVP_MD_CTX_create
| 
/home/jeroen/software/venus-upstream/build/tmp-glibc/work/cortexa8hf-neon-ve-linux-gnueabi/php/5.6.36-r0/php-5.6.36/ext/openssl/openssl.c: 
In function 'zif_openssl_verify':
| 
/home/jeroen/software/venus-upstream/build/tmp-glibc/work/cortexa8hf-neon-ve-linux-gnueabi/php/5.6.36-r0/php-5.6.36/ext/openssl/openssl.c:4859:17: 
error: storage size of 'md_ctx' isn't known
|   EVP_MD_CTX     md_ctx;
|                  ^~~~~~
| 
/home/jeroen/software/venus-upstream/build/tmp-glibc/work/cortexa8hf-neon-ve-linux-gnueabi/php/5.6.36-r0/php-5.6.36/ext/openssl/openssl.c: 
In function 'zif_openssl_seal':
| 
/home/jeroen/software/venus-upstream/build/tmp-glibc/work/cortexa8hf-neon-ve-linux-gnueabi/php/5.6.36-r0/php-5.6.36/ext/openssl/openssl.c:4920:17: 
error: storage size of 'ctx' isn't known
|   EVP_CIPHER_CTX ctx;
|                  ^~~
| 
/home/jeroen/software/venus-upstream/build/tmp-glibc/work/cortexa8hf-neon-ve-linux-gnueabi/php/5.6.36-r0/php-5.6.36/ext/openssl/openssl.c: 
In function 'zif_openssl_open':
| 
/home/jeroen/software/venus-upstream/build/tmp-glibc/work/cortexa8hf-neon-ve-linux-gnueabi/php/5.6.36-r0/php-5.6.36/ext/openssl/openssl.c:5048:17: 
error: storage size of 'ctx' isn't known
|   EVP_CIPHER_CTX ctx;
|                  ^~~
| 
/home/jeroen/software/venus-upstream/build/tmp-glibc/work/cortexa8hf-neon-ve-linux-gnueabi/php/5.6.36-r0/php-5.6.36/ext/openssl/openssl.c: 
In function 'zif_openssl_digest':
| 
/home/jeroen/software/venus-upstream/build/tmp-glibc/work/cortexa8hf-neon-ve-linux-gnueabi/php/5.6.36-r0/php-5.6.36/ext/openssl/openssl.c:5154:13: 
error: storage size of 'md_ctx' isn't known
|   EVP_MD_CTX md_ctx;
|              ^~~~~~
| 
/home/jeroen/software/venus-upstream/build/tmp-glibc/work/cortexa8hf-neon-ve-linux-gnueabi/php/5.6.36-r0/php-5.6.36/ext/openssl/openssl.c: 
In function 'zif_openssl_encrypt':
| 
/home/jeroen/software/venus-upstream/build/tmp-glibc/work/cortexa8hf-neon-ve-linux-gnueabi/php/5.6.36-r0/php-5.6.36/ext/openssl/openssl.c:5233:17: 
error: storage size of 'cipher_ctx' isn't known
|   EVP_CIPHER_CTX cipher_ctx;
|                  ^~~~~~~~~~
| 
/home/jeroen/software/venus-upstream/build/tmp-glibc/work/cortexa8hf-neon-ve-linux-gnueabi/php/5.6.36-r0/php-5.6.36/ext/openssl/openssl.c: 
In function 'zif_openssl_decrypt':
| 
/home/jeroen/software/venus-upstream/build/tmp-glibc/work/cortexa8hf-neon-ve-linux-gnueabi/php/5.6.36-r0/php-5.6.36/ext/openssl/openssl.c:5316:17: 
error: storage size of 'cipher_ctx' isn't known
|   EVP_CIPHER_CTX cipher_ctx;