[oe] [meta-multimedia][PATCH] mpd: fix yocto-check-layer issue with mulitmedia

Martin Jansa martin.jansa at gmail.com
Sun Sep 30 05:54:26 UTC 2018


https://www.kernel.org/doc/html/latest/process/submitting-patches.html

The --- marker line serves the essential purpose of marking for patch
handling tools where the changelog message ends.

One good use for the additional comments after the --- marker is for a
diffstat, to show what files have changed, and the number of inserted and
deleted lines per file. A diffstat is especially useful on bigger patches.
Other comments relevant only to the moment or the maintainer, not suitable
for the permanent changelog, should also go here. A good example of such
comments might be patch changelogs which describe what has changed between
the v1 and v2 version of the patch.


On Sat, Sep 29, 2018 at 10:16 PM akuster808 <akuster808 at gmail.com> wrote:

>
>
> On 09/29/2018 12:46 PM, Martin Jansa wrote:
>
> On Sat, Sep 29, 2018 at 12:31:05PM -0700, Armin Kuster wrote:
>
> ERROR: Nothing PROVIDES 'faad2' (but /home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb DEPENDS on or otherwise requires it)
>
> enable aac only if LICENSE_FLAGS is commercial
>
> [v2]
> fix typo in commit message
> rebase on latest master
>
>
> This belongs to cover later or under ---.
>
> I failed to have a [V2] in the subject.  I guess a V3 is inorder for that.
>
> Can you point me to the doc that says where a [v2] comments in a git
> header should be. I can not find it. I seem to be reminded that when I do
> revisions I am doing them wrong.
>
> I don't see reference to this policy:
> https://www.openembedded.org/wiki/Styleguide#Patches
> https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
>
> per kernel process:
> "The --- marker line serves the essential purpose of marking for patch
> handling tools where the changelog message ends."
> Are you saying I should violate that?
>
> is there somewhere else I should be looking?
>
> - armin
>
>
>
> Signed-off-by: Armin Kuster <akuster808 at gmail.com> <akuster808 at gmail.com>
> ---
>  meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> index 9123673fb..f91ce4d62 100644
> --- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> +++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> @@ -26,7 +26,8 @@ S = "${WORKDIR}/git"
>  EXTRA_OECONF = "enable_bzip2=yes"
>  EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}" <$%7B at bb.utils.contains('DISTRO_FEATURES','systemd','--with-systemdsystemunitdir=$%7Bsystemd_unitdir%7D/system/','--without-systemdsystemunitdir',d)%7D>
>
> -PACKAGECONFIG ??= "aac alsa ao bzip2 daemon ffmpeg fifo flac fluidsynth iso9660 jack libsamplerate libwrap httpd mms mpg123 modplug sndfile upnp openal opus oss recorder vorbis wavpack zlib"
> +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib"
> +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}" <$%7B at bb.utils.contains('LICENSE_FLAGS','commercial','aac','',d)%7D>
>
>
> This removes much more than just aac now.
>
> Why did you remove daemon, fifo, libwrap, httpd, oss, recorder, vorbis?
>
>
>
>  PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2"
>  PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing listOpenembedded-devel at lists.openembedded.orghttp://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
>



More information about the Openembedded-devel mailing list