[oe] [meta-oe][PATCH 2/3] cppzmq: bump version 4.2.3 => 4.3.1

[Vincent Prince]

Adrien,

What I'm not sure to understand is in which case we use "_git.bb" instead
of having PV in filename.
If we use a release version, shouldn't we point to
https://github.com/zeromq/cppzmq/archive/v4.3.0.tar.gz?
And if we use git version, shouldn't we specify git commit hash to remove
any ambiguity between PV and SRCREV?
Do you know any convention is specified somewhere?

Regards,
Vincent

Le mer. 3 avr. 2019 à 13:15, Adrian Bunk <bunk at stusta.de> a écrit :

> On Wed, Apr 03, 2019 at 12:42:13PM +0200, Vincent Prince wrote:
> > Then, it would need to rename cppzmq_git.bb into cppzmq_4.3.1.git or
> can we
> > just remove +git${SRCPV} part of PV?
> >
> > In following threads it seems first option should be chosen?
> >
> https://www.mail-archive.com/openembedded-core@lists.openembedded.org/msg120575.html
> >...
>
> That is about putting PV in the recipe filename instead of "git",
> in this case the discussion would be cppzmq_git.bb versus cppzmq_4.3.1.bb
>
> I am not aware of anyone arguing against PV having a proper
> version (without +git) for a release.
>
> > Le mer. 3 avr. 2019 à 10:56, Adrian Bunk <bunk at stusta.de> a écrit :
> > > On Wed, Apr 03, 2019 at 10:28:42AM +0200, Vincent Prince wrote:
> >...
> > > > diff --git a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > > b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > > > index 9aff59c..2f99417 100644
> > > > --- a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > > > +++ b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
> > > > @@ -4,8 +4,8 @@ LICENSE = "MIT"
> > > >  LIC_FILES_CHKSUM =
> "file://LICENSE;md5=db174eaf7b55a34a7c89551197f66e94"
> > > >  DEPENDS = "zeromq"
> > > >
> > > > -SRCREV = "6aa3ab686e916cb0e62df7fa7d12e0b13ae9fae6"
> > > > -PV = "4.2.3+git${SRCPV}"
> > > > +SRCREV = "213da0b04ae3b4d846c9abc46bab87f86bfb9cf4"
> > > > +PV = "4.3.1+git${SRCPV}"
> > > >...
> > >
> > > These are the actual releases, PV should not say +git${SRCPV}
> > > for them.
> > >
> > > Not a bug you introduced, but can be fixed now.
> > >
> > > cu
> > > Adrian
>
> cu
> Adrian
>
> --
>
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
>
>