[oe] [meta-oe][PATCH 2/3] cppzmq: bump version 4.2.3 => 4.3.1

[Khem Raj]

Sure, go ahead.

On Thu, Apr 4, 2019 at 2:12 AM Vincent Prince <vincent.prince.fr at gmail.com>
wrote:

> I just look at cppzmq, and version is only 4.3.0 and not 4.3.1, my mistake.
>
> By the way, 4.3.0 version uses googletest for tests and I disabled it
> because cmake fetcher hangs,
> Moreover, master version uses another test framework (catch), so it will
> be quite some work to add googletest support then remove it for next
> version.
>
> Khem, do you think I can keep EXTRA_OECMAKE = "-DCPPZMQ_BUILD_TESTS=OFF"
> for now with this explanation in commit log?
> Will send v3 after your decision,
>
> Thanks,
> Vincent
>
>
> Le mer. 3 avr. 2019 à 21:33, Vincent Prince <vincent.prince.fr at gmail.com>
> a écrit :
>
>> Hi Khem,
>>
>> To be honest I disabled it because I don't have much time to add ptest
>> stuff and I had a failure with it.
>> I'll try to rework that part and at least put it in a packageconfig knob
>> as suggested.
>>
>> Thanks for review,
>> Vincent
>>
>> Le mer. 3 avr. 2019 à 18:52, Khem Raj <raj.khem at gmail.com> a écrit :
>>
>>> On Wed, Apr 3, 2019 at 1:30 AM Vincent Prince
>>> <vincent.prince.fr at gmail.com> wrote:
>>> >
>>> > Signed-off-by: Vincent Prince <vincent.prince.fr at gmail.com>
>>> > ---
>>> >  meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb | 6 ++++--
>>> >  1 file changed, 4 insertions(+), 2 deletions(-)
>>> >
>>> > diff --git a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
>>> b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
>>> > index 9aff59c..2f99417 100644
>>> > --- a/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
>>> > +++ b/meta-oe/recipes-connectivity/zeromq/cppzmq_git.bb
>>> > @@ -4,8 +4,8 @@ LICENSE = "MIT"
>>> >  LIC_FILES_CHKSUM =
>>> "file://LICENSE;md5=db174eaf7b55a34a7c89551197f66e94"
>>> >  DEPENDS = "zeromq"
>>> >
>>> > -SRCREV = "6aa3ab686e916cb0e62df7fa7d12e0b13ae9fae6"
>>> > -PV = "4.2.3+git${SRCPV}"
>>> > +SRCREV = "213da0b04ae3b4d846c9abc46bab87f86bfb9cf4"
>>> > +PV = "4.3.1+git${SRCPV}"
>>> >
>>> >  SRC_URI = "git://github.com/zeromq/cppzmq.git"
>>> >
>>> > @@ -13,6 +13,8 @@ S = "${WORKDIR}/git"
>>> >
>>> >  inherit cmake
>>> >
>>> > +EXTRA_OECMAKE = "-DCPPZMQ_BUILD_TESTS=OFF"
>>> > +
>>>
>>> explaining why tests are disabled would be helpful for future changes
>>> where someone might
>>> want to enable it and if its an optimization then turn it into
>>> packageconfig knob.
>>>
>>> >  PACKAGES = "${PN}-dev"
>>> >
>>> >  RDEPENDS_${PN}-dev = "zeromq-dev"
>>> > --
>>> > 2.7.4
>>> >
>>> > --
>>> > _______________________________________________
>>> > Openembedded-devel mailing list
>>> > Openembedded-devel at lists.openembedded.org
>>> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>>
>>