[oe] [meta-networking][PATCH] squid: upgrade squid 3.5.28 -> 4.6

[Andrej Valek]

I think, my changes are backport-compatible.

The esi feature was not enabled int the previous version. It means, that
libxml2/expat was also not required. In the current version, they have
invert the logic. So it needs to be explicitly disabled.
I have added on option to enable/disable openssl support. Previous
version has openssl disabled.

Regards,
Andrej

On 4/9/19 12:05 PM, Adrian Bunk wrote:
> On Tue, Apr 09, 2019 at 10:46:21AM +0200, Andrej Valek wrote:
>> ...
>>  - add openssl and esi as package options
>> ...
>> -DEPENDS = "libtool krb5 openldap db cyrus-sasl openssl expat libxml2"
>> ...
>> +DEPENDS = "libtool krb5 openldap db cyrus-sasl"
>>  
>>  inherit autotools pkgconfig useradd ptest perlnative
>>  
>> @@ -51,6 +50,8 @@ PACKAGECONFIG[libnetfilter-conntrack] = "--with-netfilter-conntrack=${includedir
>>  PACKAGECONFIG[noatomics] = "squid_cv_gnu_atomics=no,squid_cv_gnu_atomics=yes,,"
>>  PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,"
>>  PACKAGECONFIG[werror] = "--enable-strict-error-checking,--disable-strict-error-checking,"
>> +PACKAGECONFIG[esi] = "--enable-esi,--disable-esi,expat libxml2"
>> +PACKAGECONFIG[ssl] = "--with-openssl=yes,--with-openssl=no,openssl"
>> ...
> 
> It would be good to have such changes unrelated to the upgrade in a 
> separate commit.
> 
> Unless there's a reason to do otherwise, it would be better to have 
> these new options in the default PACKAGECONFIG so that a opt-out is 
> possible but the default doesn't change.
> 
> cu
> Adrian
>