[oe] [meta-oe][PATCH] cpupower: update license file checksum

Martin Jansa martin.jansa at gmail.com
Mon Apr 22 20:15:35 UTC 2019


NAK

This completely defeats the purpose of LIC_FILES_CHKSUM.

If the COPYING file vary across releases than LIC_FILES_CHKSUM should be
updated when needed while verifying that the LICENSE value is still correct.

If you use COMMON_LICENSE_DIR and completely ignore the license in the
source, then it won't ever warn the user that the license was changed while
upgrading to newer release.

On Mon, Apr 22, 2019 at 10:09 PM Daniel Díaz <daniel.diaz at linaro.org> wrote:

> The Linux kernel is GPLv2, at least as far cpupower is
> concerned. Because this recipe reuses the kernel code, and
> said source code can (does) vary across different releases,
> it's best to refer to license by its name.
>
> Use GPL-2.0 from OE common license dir.
>
> Signed-off-by: Daniel Díaz <daniel.diaz at linaro.org>
> ---
>  meta-oe/recipes-kernel/cpupower/cpupower.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-kernel/cpupower/cpupower.bb
> b/meta-oe/recipes-kernel/cpupower/cpupower.bb
> index 928973871..c7ea087a5 100644
> --- a/meta-oe/recipes-kernel/cpupower/cpupower.bb
> +++ b/meta-oe/recipes-kernel/cpupower/cpupower.bb
> @@ -2,7 +2,7 @@ SUMMARY = "Shows and sets processor power related values"
>  DESCRIPTION = "cpupower is a collection of tools to examine and tune
> power \
>  saving related features of your processor."
>  LICENSE = "GPLv2"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=bbea815ee2795b2f4230826c0c6b8814"
> +LIC_FILES_CHKSUM =
> "file://${COMMON_LICENSE_DIR}/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6"
>  DEPENDS = "pciutils gettext-native"
>  PROVIDES = "virtual/cpupower"
>
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>


More information about the Openembedded-devel mailing list