[oe] [meta-oe][PATCH 1/1] php: zlib and zip support

[Slater, Joseph]

That's probably best.  The bundled way won't be supported at some future date, anyway.      Joe

-----Original Message-----
From: Adrian Bunk <bunk at stusta.de> 
Sent: Monday, August 12, 2019 9:50 PM
To: Slater, Joseph <joe.slater at windriver.com>
Cc: openembedded-devel at lists.openembedded.org
Subject: Re: [oe] [meta-oe][PATCH 1/1] php: zlib and zip support

On Mon, Aug 12, 2019 at 12:22:20PM -0700, Joe Slater wrote:
> Add back zlib support.  Define zip support but do not enable it.
>...
> +# For zip, select one or none.  oldzip uses a bundled library and is deprecated.
> +#
> +PACKAGECONFIG[newzip] = "--enable-zip --with-libzip=${STAGING_EXECPREFIXDIR},,libzip"
> +PACKAGECONFIG[oldzip] = "--enable-zip --without-libzip,"
>...

Any reason why this can't be PACKAGECONFIG[zip] for the external libzip only without any option for the bundled library?

Bundled libraries are usually behind on security fixes, and php is a software where this tends to matter.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed