[oe] [meta-oe][V2][PATCH 1/1] php: zlib and zip support

[Randy MacLeod]

On 8/15/19 9:26 PM, Slater, Joseph wrote:
> I think the current config does not enable either zlib or zip.  It defines --with-libzip, but does not enable it with --enable-zip.  It also does not define --with-zlib, so we lose that.
> 
> The original concern was that phoronix-test-suite would put out a message at runtime that it needed php zip.  I think this message is wrong and all it needs is zlib.  So, I decided to bring both back but not enable zip because it needs an extra package.  The "old" way of supporting php zip used a bundled library.  That way has been deprecated, so if we want zip, we need libzip.
> 
> This patch is aimed at helping phoronix-test-suite and easing php zip support should someone desire to add that via PACKAGECONFIG.  I would be happy to put zip into the default config, but who really needs it?
> 

The context is good to know.

I read your v2 patch too quickly so now that you have explained
what's going on and I see that:
   zlib !- libzip
I withdraw my request for additional long log. Sorry for the noise.

../Randy

> Joe
> 
> -----Original Message-----
> From: MacLeod, Randy <Randy.MacLeod at windriver.com>
> Sent: Thursday, August 15, 2019 4:01 PM
> To: Slater, Joseph <joe.slater at windriver.com>; openembedded-devel at lists.openembedded.org
> Subject: Re: [meta-oe][V2][PATCH 1/1] php: zlib and zip support
> 
> On 8/15/19 5:26 PM, Joe Slater wrote:
>> Add back zlib support.  Define zip support but do not enable it.
> 
> Can you explain what that achieves.
>   From the change it looks like you have duplicated the default config and added a PACKAGECONFIG. Why do you need both?
> 
> ../Randy
>>
>> Signed-off-by: Joe Slater <joe.slater at windriver.com>
>> ---
>>    meta-oe/recipes-devtools/php/php.inc | 4 +++-
>>    1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-oe/recipes-devtools/php/php.inc
>> b/meta-oe/recipes-devtools/php/php.inc
>> index 33bcf12..b63ed4c 100644
>> --- a/meta-oe/recipes-devtools/php/php.inc
>> +++ b/meta-oe/recipes-devtools/php/php.inc
>> @@ -59,7 +59,7 @@ EXTRA_OECONF = "--enable-mbstring \
>>                    --enable-fpm \
>>                    --with-libdir=${baselib} \
>>                    --with-gettext=${STAGING_LIBDIR}/.. \
>> -                --with-libzip=${STAGING_LIBDIR}/.. \
>> +                --with-zlib=${STAGING_LIBDIR}/.. \
>>                    --with-iconv=${STAGING_LIBDIR}/.. \
>>                    --with-bz2=${STAGING_DIR_TARGET}${exec_prefix} \
>>                    
>> --with-config-file-path=${sysconfdir}/php/apache2-php${PHP_MAJOR_VERSION} \ @@ -81,6 +81,8 @@ PACKAGECONFIG ??= "mysql sqlite3 imap opcache openssl \
>>    "
>>    PACKAGECONFIG_class-native = ""
>>    
>> +PACKAGECONFIG[zip] = "--enable-zip --with-libzip=${STAGING_EXECPREFIXDIR},,libzip"
>> +
>>    PACKAGECONFIG[mysql] = "--with-mysql=${STAGING_DIR_TARGET}${prefix} \
>>                            --with-mysqli=${STAGING_BINDIR_CROSS}/mysql_config \
>>                            
>> --with-pdo-mysql=${STAGING_BINDIR_CROSS}/mysql_config \
>>
> 
> 
> --
> # Randy MacLeod
> # Wind River Linux
> 


-- 
# Randy MacLeod
# Wind River Linux